Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude MCP from system prompt if mode does not support it #1340

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

mrubens
Copy link
Collaborator

@mrubens mrubens commented Mar 3, 2025

Context

#1000

Implementation

If MCP isn't supported by the mode, exclude that part of the prompt.


Important

Exclude MCP instructions from prompts in system.ts if the mode does not support MCP.

  • Behavior:
    • In generatePrompt in system.ts, exclude MCP instructions if the mode does not support MCP by checking modeConfig.groups.
  • Misc:
    • Add getGroupName import in system.ts to facilitate MCP support check.
    • Add changeset file fluffy-pumpkins-sip.md to document the patch.

This description was created by Ellipsis for 003cd1b. It will automatically update as commits are pushed.

@mrubens mrubens requested a review from cte as a code owner March 3, 2025 15:48
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 3, 2025
@dosubot dosubot bot added lgtm This PR has been approved by a maintainer enhancement New feature or request labels Mar 3, 2025
@mrubens mrubens merged commit 56761ec into main Mar 3, 2025
18 checks passed
@mrubens mrubens deleted the exclude_mcp_from_modes_where_not_supported branch March 3, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants