Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning if checkpoints are taking too long to load #1342

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

mrubens
Copy link
Collaborator

@mrubens mrubens commented Mar 3, 2025

Context

We're hearing about some issues initializing checkpoints that cause the whole task to hang. We still need to get to the bottom of this, but in the meantime this adds a UI element after 5 seconds with a link to settings to disable checkpoints.

Implementation

It works by setting a timer for 5 seconds and checking if there are any messages in the chat.

Screenshots

Screen_Recording_2025-03-03_at_11.08.39_AM.mov

How to Test

I tested by adding a 10 second day to the ShadowCheckpointService initialization.


Important

Adds a warning in ChatView to notify users if checkpoints take longer than 5 seconds to load, with an option to disable checkpoints in settings.

  • Behavior:
    • Adds a warning in ChatView if checkpoints take longer than 5 seconds to load.
    • Warning includes a link to disable checkpoints in settings.
  • Implementation:
    • Uses useEffect to set a 5-second timer in ChatView.tsx.
    • Displays warning if no messages are visible and task is not streaming.
    • Hides warning when messages appear or task starts streaming.
  • UI Components:
    • Adds CheckpointWarningMessage component in ChatView.tsx.

This description was created by Ellipsis for cd46ab5. It will automatically update as commits are pushed.

@mrubens mrubens requested a review from cte as a code owner March 3, 2025 16:15
Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: cd46ab5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 3, 2025
Copy link
Collaborator

@cte cte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 3, 2025
@mrubens mrubens merged commit 9f374ab into main Mar 3, 2025
16 checks passed
@mrubens mrubens deleted the checkpoint_delay_warning branch March 3, 2025 16:21
@dosubot dosubot bot added the enhancement New feature or request label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants