Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadcn/ui dropdown menu component #760

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Add shadcn/ui dropdown menu component #760

merged 5 commits into from
Feb 3, 2025

Conversation

cte
Copy link
Collaborator

@cte cte commented Feb 3, 2025

Description

This is for use in the UI for checkpoints.

https://www.loom.com/share/f6ab3ff58fd7436bafc534fc119e0f3c?sid=b3cbd93e-7027-43ac-99c2-05c8b261e95a

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Add DropdownMenu component using @radix-ui/react-dropdown-menu and update related CSS and Storybook configurations.

  • New Feature:
    • Add DropdownMenu component in dropdown-menu.tsx using @radix-ui/react-dropdown-menu.
    • Add DropdownMenu stories in DropdownMenu.stories.tsx.
  • Dependencies:
    • Add @radix-ui/react-dropdown-menu and @radix-ui/react-icons to package.json.
  • CSS:
    • Update index.css to use custom preflight styles from preflight.css.
    • Add preflight.css for custom CSS resets.
  • Storybook:
    • Remove @chromatic-com/storybook and @storybook/addon-onboarding from main.ts and package.json.

This description was created by Ellipsis for 684f89c. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 684f89c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

*/

*,
::after,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple pseudo-element selectors use triple-colon syntax (e.g. :::after, :::before, :::backdrop, :::file-selector-button). The standard is double-colon (e.g. ::after). Please update these selectors as they may not work consistently across browsers. This applies to similar occurrences (lines 8-11, 282, 291, 308, 317, 326, 334, 338, 372). See our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d5818051ae9cefd92c3aac2b

@cte cte merged commit 6f64975 into main Feb 3, 2025
6 checks passed
@cte cte deleted the cte/dropdown-menu branch February 3, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants