Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): update regex pattern to include more separator lines #187

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

penandlim
Copy link
Contributor

The reportSeparatorRegex is missing a couple of new separators.

This is what the --gas-report output currently looks like for forge 0.3.0 (55badd4 2025-01-17T00:21:10.590438000Z)

Suite result: ok. 96 passed; 0 failed; 0 skipped; finished in 352.58s (3137.75s CPU time)

╭----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------╮
| dependencies/euler-price-oracle-1/src/EulerRouter.sol:EulerRouter Contract |                 |       |        |       |         |
+=================================================================================================================================+
| Deployment Cost                                                            | Deployment Size |       |        |       |         |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| 752721                                                                     | 3467            |       |        |       |         |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
|                                                                            |                 |       |        |       |         |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                                                              | Min             | Avg   | Median | Max   | # Calls |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| getQuote                                                                   | 2375            | 4471  | 2377   | 8877  | 32821   |
|----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| govSetConfig                                                               | 29030           | 45203 | 48930  | 49146 | 1914    |
╰----------------------------------------------------------------------------+-----------------+-------+--------+-------+---------╯

This PR updates the regex so it includes these separator lines as well.
+=======+
| |

Fixes #186

@Rubilmax
Copy link
Owner

Thank you for this! It looks like they changed the format again (because this separator was a simple line at the time I fixed the issue)

Let me double check this regex wrt backward compatibility, and I'll approve that!

@Rubilmax Rubilmax merged commit 4cdca35 into Rubilmax:main Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foundry's update on gas report output breaks compatibility
2 participants