Switch to Eclipse Compiler in mvn-compiler

maven-compiler-eclipse-jdt-configuration.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<profiles version="14">
+ <profile kind="CodeFormatterProfile" name="spark_rumble_code_style" version="1">
+  <setting id="org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess" value="error"/>
+  <setting id="org.eclipse.jdt.core.compiler.release" value="enabled"/>
+  <setting id="org.eclipse.jdt.core.compiler.problem.enumIdentifier" value="error"/>
+  <setting id="org.eclipse.jdt.core.compiler.problem.assertIdentifier" value="error"/>
+  <setting id="org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode" value="enabled"/>
+  <setting id="org.eclipse.jdt.core.compiler.source" value="10"/>
+  <setting id="org.eclipse.jdt.core.compiler.codegen.targetPlatform" value="10"/>
+  <setting id="org.eclipse.jdt.core.compiler.compliance" value="10"/>
+ </profile>
+</profiles>

pom.xml

@@ -42,9 +42,25 @@
                 <artifactId>maven-compiler-plugin</artifactId>
                 <version>3.8.1</version>
                 <configuration>
+                    <compilerId>eclipse</compilerId>
                     <source>1.8</source>
                     <target>1.8</target>
+                    <compilerArguments>
+                        <properties>${basedir}/maven-compiler-eclipse-jdt-configuration.xml</properties>
+                    </compilerArguments>
                 </configuration>
+                <dependencies>
+                    <dependency>
+                        <groupId>org.codehaus.plexus</groupId>
+                        <artifactId>plexus-compiler-eclipse</artifactId>
+                        <version>2.8.5</version>
+                    </dependency>
+                    <dependency>
+                        <groupId>org.eclipse.jdt</groupId>
+                        <artifactId>ecj</artifactId>
+                        <version>3.20.0</version>
+                    </dependency>
+                </dependencies>
             </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
@@ -163,7 +179,7 @@
                 <configuration>
                     <java>
                         <eclipse>
-                            <file>${basedir}/codetemplates-eclipse.xml</file>
+                            <file>${basedir}/spotless-formatter-eclipse-jdt-configurations.xml</file>
                         </eclipse>
                     </java>
                 </configuration>

codetemplates-eclipse.xml → spotless-formatter-eclipse-jdt-configurations.xml

@@ -38,7 +38,6 @@
   <setting id="org.eclipse.jdt.core.formatter.parentheses_positions_in_if_while_statement" value="separate_lines_if_wrapped"/>
   <setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_enum_constant" value="48"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_angle_bracket_in_parameterized_type_reference" value="do not insert"/>
-  <setting id="org.eclipse.jdt.core.compiler.release" value="enabled"/>
   <setting id="org.eclipse.jdt.core.formatter.comment.indent_root_tags" value="true"/>
   <setting id="org.eclipse.jdt.core.formatter.wrap_before_or_operator_multicatch" value="true"/>
   <setting id="org.eclipse.jdt.core.formatter.enabling_tag" value="@formatter:on"/>
@@ -64,7 +63,6 @@
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_parenthesized_expression" value="do not insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_new_line_after_annotation_on_enum_constant" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.never_indent_line_comments_on_first_column" value="false"/>
-  <setting id="org.eclipse.jdt.core.compiler.problem.enumIdentifier" value="error"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_and_in_type_parameter" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_for_inits" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.indent_statements_compare_to_block" value="true"/>
@@ -115,7 +113,6 @@
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_method_invocation_arguments" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_method_invocation" value="52"/>
   <setting id="org.eclipse.jdt.core.formatter.alignment_for_throws_clause_in_constructor_declaration" value="64"/>
-  <setting id="org.eclipse.jdt.core.compiler.problem.assertIdentifier" value="error"/>
   <setting id="org.eclipse.jdt.core.formatter.comment.clear_blank_lines_in_block_comment" value="false"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_new_line_before_catch_in_try_statement" value="false"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_try" value="insert"/>
@@ -163,7 +160,6 @@
   <setting id="org.eclipse.jdt.core.formatter.alignment_for_arguments_in_allocation_expression" value="48"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_method_invocation" value="do not insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_while" value="insert"/>
-  <setting id="org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode" value="enabled"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_switch" value="do not insert"/>
   <setting id="org.eclipse.jdt.core.formatter.alignment_for_method_declaration" value="0"/>
   <setting id="org.eclipse.jdt.core.formatter.join_wrapped_lines" value="false"/>
@@ -181,7 +177,6 @@
   <setting id="org.eclipse.jdt.core.formatter.parentheses_positions_in_try_clause" value="separate_lines_if_wrapped"/>
   <setting id="org.eclipse.jdt.core.formatter.alignment_for_selector_in_method_invocation" value="84"/>
   <setting id="org.eclipse.jdt.core.formatter.never_indent_block_comments_on_first_column" value="false"/>
-  <setting id="org.eclipse.jdt.core.compiler.source" value="10"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_synchronized" value="do not insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_constructor_declaration_throws" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.tabulation.size" value="4"/>
@@ -203,7 +198,6 @@
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_parenthesized_expression_in_throw" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.wrap_before_assignment_operator" value="false"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_colon_in_labeled_statement" value="do not insert"/>
-  <setting id="org.eclipse.jdt.core.compiler.codegen.targetPlatform" value="10"/>
   <setting id="org.eclipse.jdt.core.formatter.brace_position_for_switch" value="end_of_line"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_superinterfaces" value="do not insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_method_declaration_parameters" value="insert"/>
@@ -273,7 +267,6 @@
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_method_declaration" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_type_parameters" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_catch" value="do not insert"/>
-  <setting id="org.eclipse.jdt.core.compiler.compliance" value="10"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_closing_bracket_in_array_reference" value="do not insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_annotation" value="insert"/>
   <setting id="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_enum_constant_arguments" value="do not insert"/>