UI Common Build Fixes #13
Conversation
| import {theme} from "../../../styles/theme/theme"; | ||
|
|
||
| type AqueductQuadraticProps = { |
There was a problem hiding this comment.
These are no longer needed and we can just use the built in EdgeProps type that comes with react-flow.
|
|
||
| type AqueductBezierProps = { |
There was a problem hiding this comment.
These are no longer needed and we can just use the built in EdgeProps type that comes with react-flow.
| import {theme} from "../../../styles/theme/theme"; | ||
|
|
||
| type AqueductStraightProps = { |
There was a problem hiding this comment.
These are no longer needed and we can just use the built in EdgeProps type that comes with react-flow.
| @@ -25,7 +25,6 @@ import { | |||
| RelationalDBExtractParams, | |||
| RelationalDBLoadParams | |||
| } from "../../../utils/operators"; | |||
| import { CopyBlock } from "react-code-blocks"; | |||
There was a problem hiding this comment.
CopyBlock is giving us some trouble with building, so removing it for now.
We should revisit and find another component to use for the code blocks/copying in another task.
@vsreekanti I noticed that there is a related PR here:
https://github.com/aqueducthq/enterprise/pull/521
Perhaps @Boyuan-Deng can take this on as some future work?
| @@ -10,12 +10,6 @@ import AqueductQuadratic from "../components/workflows/edges/AqueductQuadratic"; | |||
|
|
|||
| const { httpProtocol, apiAddress } = useAqueductConsts(); | |||
|
|
|||
| export const INITIAL_DATABASE_NODE_ID = 'initial_database'; | |||
There was a problem hiding this comment.
Also no longer used, so yanked them out
agiron123
force-pushed
the
ENG-1109-use-ui-common-common-changes
branch
from
d1efc82 to
5a85bd3
Compare
src/ui/app/package-lock.json
Outdated
| @@ -1,9411 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
Was this intentionally removed @agiron123?
There was a problem hiding this comment.
I took this out to get fresh packages, but I expected it to be re-generated again for me. When installing via npm link apparently this does not get generated.
I will go ahead and publish the common package and re-generate this file before merging.
There was a problem hiding this comment.
So there was some weirdness with the package-lock being regenerated properly and what not.
Instead there is another package to use, according to this github thread:
rogeriochaves/npm-force-resolutions#36
Things are now working properly and this package is now used in both common and app.
Fixes build errors on ui-common and app. Bumps version of ui-common to latest version. (0.0.4 at time of writing)
Changes to fix build issues with aqueducthq/common. Also updates version number to 0.0.3.
Related to:
https://linear.app/aqueducthq/issue/ENG-1109/refactor-ui-enterprise-to-import-from-ui-components-package