ssh-key: externally generated signatures for certificates #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest following the existing pattern for the |
tarcieri
reviewed
Feb 9, 2025
Comment on lines
+67
to
+79
| /// Sign the provided message bytestring using `Self` (e.g. a cryptographic key | ||
| /// or connection to an HSM), returning a digital signature. | ||
| pub trait AsyncSigner<S> { | ||
| // Using an associated type here to force the implementor to be explicit with Send/Sync | ||
| /// Future type which will be returned by `try_sign` | ||
| type SignFuture: Future<Output = signature::Result<S>>; | ||
| /// Attempt to sign the given message, returning a digital signature on | ||
| /// success, or an error if something went wrong. | ||
| /// | ||
| /// The main intended use case for signing errors is when communicating | ||
| /// with external signers, e.g. cloud KMS, HSMs, or other hardware tokens. | ||
| fn try_sign(&self, msg: &[u8]) -> Self::SignFuture; | ||
| } |
There was a problem hiding this comment.
Please use the upstream trait from async-signature (which we plan on merging into the signature crate soon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an async function
with_signerto the certificate builder to delegate the signature generation to an user defined function such an fido2 implementation to sign an certificate using an security key.I'd really prefer to use an async closure instead of
Fn(&[u8]) -> impl Futurehowever that would require bumping rust-version to 1.84