block-buffer: remove dependency on crypto-common #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
force-pushed
the
block-buffer/monomorph_error
branch
from
1592eca
to
ac65c94
Compare
tarcieri
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency on
crypto-commoncauses some annoyances as mentioned in RustCrypto/traits#1662.Instead of using the sealed
BlockSizestrait, the new code uses monomorphization errors to enforce block size correctness. This is somewhat non-idiomatic, but should be fine in practice since block buffers are usually used with fixed block sizes. After this changeBlockSizesprobably can be removed fromcrypto-common.I decided against vendoring
block-buffercode intodigestas was proposed in the linked issue becauseblock-bufferhas third-party users and having a separate crate should make it a bit easier for reviewers.