🏥 Source Bing Ads:Fix basic read: add ignored fields, update expected…

… records (airbytehq#35630)
Ruy-Araujo · Feb 27, 2024 · ab2f67a · ab2f67a
1 parent 56d9942
commit ab2f67a
Show file tree

Hide file tree

Showing 2 changed files with 74 additions and 1 deletion.
diff --git a/airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml b/airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml
@@ -91,6 +91,9 @@ acceptance_tests:
           - name: campaign_labels
             bypass_reason: "This stream is tested without start date"
         ignored_fields:
+          campaigns:
+            - name: Status
+              bypass_reason: "Status can be changed"
           ads:
             - name: Descriptions/AssetLink/*/AssetPerformanceLabel
               bypass_reason: "This field indicates the asset's performance and is dynamically updated by the API."
@@ -136,6 +139,12 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: FirstPageBid
               bypass_reason: "dynamic field"
+            - name: FirstPageBid
+              bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
           campaign_impression_performance_report_weekly:
             - name: Impressions
               bypass_reason: "dynamic field"
@@ -161,6 +170,16 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: LandingPageExperience
               bypass_reason: "dynamic field"
+            - name: CampaignStatus
+              bypass_reason: "dynamic field"
+            - name: ReturnOnAdSpend
+              bypass_reason: "dynamic field"
+            - name: AllReturnOnAdSpend
+              bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
           campaign_performance_report_weekly:
             - name: Impressions
               bypass_reason: "dynamic field"
@@ -188,6 +207,12 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: LowQualityClicksPercent
               bypass_reason: "dynamic field"
+            - name: CampaignStatus
+              bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
           ad_group_impression_performance_report_weekly:
             - name: Impressions
               bypass_reason: "dynamic field"
@@ -221,6 +246,16 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: LandingPageExperience
               bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
+            - name: CampaignStatus
+              bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AbsoluteTopImpressionRatePercent
+              bypass_reason: "dynamic field"
+            - name: TopImpressionRatePercent
+              bypass_reason: "dynamic field"
           ad_group_performance_report_weekly:
             - name: Impressions
               bypass_reason: "dynamic field"
@@ -242,6 +277,10 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: LandingPageExperience
               bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
           ad_performance_report_daily:
             - name: TimePeriod
               bypass_reason: "dynamic field"
@@ -327,6 +366,10 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: LandingPageExperience
               bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
           budget_summary_report:
             - name: Date
               bypass_reason: "dynamic field"
@@ -395,6 +438,16 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: LowQualityGeneralClicks
               bypass_reason: "dynamic field"
+            - name: CampaignStatus
+              bypass_reason: "dynamic field"
+            - name: ReturnOnAdSpend
+              bypass_reason: "dynamic field"
+            - name: AllReturnOnAdSpend
+              bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
           account_performance_report_daily:
             - name: Ctr
               bypass_reason: "dynamic field"
@@ -477,6 +530,16 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: ExactMatchImpressionSharePercent
               bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
+            - name: CampaignStatus
+              bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AbsoluteTopImpressionRatePercent
+              bypass_reason: "dynamic field"
+            - name: TopImpressionRatePercent
+              bypass_reason: "dynamic field"
           campaign_performance_report_daily:
             - name: Ctr
               bypass_reason: "dynamic field"
@@ -494,6 +557,12 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: LandingPageExperience
               bypass_reason: "dynamic field"
+            - name: CampaignStatus
+              bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
           keyword_performance_report_daily:
             - name: Language
               bypass_reason: "dynamic field"
@@ -537,6 +606,10 @@ acceptance_tests:
               bypass_reason: "dynamic field"
             - name: FirstPageBid
               bypass_reason: "dynamic field"
+            - name: QualityScore
+              bypass_reason: "dynamic field"
+            - name: AdRelevance
+              bypass_reason: "dynamic field"
         timeout_seconds: 9000
       - config_path: secrets/config_no_date.json
         expect_records:

diff --git a/airbyte-integrations/connectors/source-bing-ads/integration_tests/expected_records.jsonl b/airbyte-integrations/connectors/source-bing-ads/integration_tests/expected_records.jsonl
@@ -2,7 +2,7 @@
 {"stream": "ads", "data": {"AdFormatPreference": "All", "DevicePreference": 0, "EditorialStatus": "Active", "FinalAppUrls": null, "FinalMobileUrls": null, "FinalUrlSuffix": null, "FinalUrls": {"string": ["https://airbyte.com"]}, "ForwardCompatibilityMap": null, "Id": 84800390693061, "Status": "Active", "TrackingUrlTemplate": null, "Type": "ResponsiveSearch", "UrlCustomParameters": null, "Descriptions": {"AssetLink": [{"Asset": {"Id": 10239363892977, "Name": null, "Type": "TextAsset", "Text": "Connect, integrate, and sync data seamlessly with Airbyte's 800+ contributors and growing!"}, "AssetPerformanceLabel": "Learning", "EditorialStatus": "Active", "PinnedField": null}, {"Asset": {"Id": 10239363892976, "Name": null, "Type": "TextAsset", "Text": "Move data like a pro with our powerful tool trusted by 40,000+ engineers worldwide!"}, "AssetPerformanceLabel": "Learning", "EditorialStatus": "Active", "PinnedField": null}]}, "Domain": "airbyte.com", "Headlines": {"AssetLink": [{"Asset": {"Id": 10239363892979, "Name": null, "Type": "TextAsset", "Text": "Get synced with Airbyte"}, "AssetPerformanceLabel": "Good", "EditorialStatus": "Active", "PinnedField": null}, {"Asset": {"Id": 10239363893384, "Name": null, "Type": "TextAsset", "Text": "Data management made easy"}, "AssetPerformanceLabel": "Best", "EditorialStatus": "Active", "PinnedField": null}, {"Asset": {"Id": 10239363892978, "Name": null, "Type": "TextAsset", "Text": "Connectors for every need"}, "AssetPerformanceLabel": "Good", "EditorialStatus": "Active", "PinnedField": null}, {"Asset": {"Id": 10239363892980, "Name": null, "Type": "TextAsset", "Text": "Industry-leading connectors"}, "AssetPerformanceLabel": "Good", "EditorialStatus": "Active", "PinnedField": null}, {"Asset": {"Id": 10239363893383, "Name": null, "Type": "TextAsset", "Text": "Try Airbyte now for free"}, "AssetPerformanceLabel": "Low", "EditorialStatus": "Active", "PinnedField": null}]}, "Path1": null, "Path2": null, "AdGroupId": 1356799861840328, "AccountId": 180519267, "CustomerId": 251186883}, "emitted_at": 1706721454075}
 {"stream": "campaigns", "data": {"AudienceAdsBidAdjustment": 0, "BiddingScheme": {"Type": "EnhancedCpc"}, "BudgetType": "DailyBudgetStandard", "DailyBudget": 2.0, "ExperimentId": null, "FinalUrlSuffix": null, "ForwardCompatibilityMap": null, "Id": 531016227, "MultimediaAdsBidAdjustment": 40, "Name": "Airbyte test", "Status": "Active", "SubType": null, "TimeZone": "CentralTimeUSCanada", "TrackingUrlTemplate": null, "UrlCustomParameters": null, "CampaignType": "Search", "Settings": {"Setting": [{"Type": "TargetSetting", "Details": {"TargetSettingDetail": [{"CriterionTypeGroup": "Audience", "TargetAndBid": false}]}}]}, "BudgetId": null, "Languages": {"string": ["English"]}, "AdScheduleUseSearcherTimeZone": false, "AccountId": 180519267, "CustomerId": 251186883}, "emitted_at": 1702903287209}
 {"stream": "accounts", "data": {"BillToCustomerId": 251186883, "CurrencyCode": "USD", "AccountFinancialStatus": "ClearFinancialStatus", "Id": 180535609, "Language": "English", "LastModifiedByUserId": 0, "LastModifiedTime": "2023-08-11T08:24:26.603000", "Name": "DEMO-ACCOUNT", "Number": "F149W3B6", "ParentCustomerId": 251186883, "PaymentMethodId": null, "PaymentMethodType": null, "PrimaryUserId": 138225488, "AccountLifeCycleStatus": "Pause", "TimeStamp": "AAAAAH10c1A=", "TimeZone": "Santiago", "PauseReason": 2, "ForwardCompatibilityMap": null, "LinkedAgencies": null, "SalesHouseCustomerId": null, "TaxInformation": null, "BackUpPaymentInstrumentId": null, "BillingThresholdAmount": null, "BusinessAddress": {"City": "San Francisco", "CountryCode": "US", "Id": 149694999, "Line1": "350 29th avenue", "Line2": null, "Line3": null, "Line4": null, "PostalCode": "94121", "StateOrProvince": "CA", "TimeStamp": null, "BusinessName": "Daxtarity Inc."}, "AutoTagType": "Inactive", "SoldToPaymentInstrumentId": null, "AccountMode": "Expert"}, "emitted_at": 1702903290287}
-{"stream":"account_performance_report_daily","data":{"AccountId":180519267,"TimePeriod":"2023-12-18","CurrencyCode":"USD","AdDistribution":"Search","DeviceType":"Computer","Network":"Syndicated search partners","DeliveredMatchType":"Exact","DeviceOS":"Windows","TopVsOther":"Syndicated search partners - Top","BidMatchType":"Broad","AccountName":"Airbyte","AccountNumber":"F149MJ18","PhoneImpressions":0,"PhoneCalls":0,"Clicks":0,"Ctr":0.0,"Spend":0.0,"Impressions":1,"CostPerConversion":null,"Ptr":null,"Assists":0,"ReturnOnAdSpend":null,"CostPerAssist":null,"AverageCpc":0.0,"AveragePosition":0.0,"AverageCpm":0.0,"Conversions":0.0,"ConversionsQualified":0.0,"ConversionRate":null,"LowQualityClicks":0,"LowQualityClicksPercent":null,"LowQualityImpressions":0,"LowQualitySophisticatedClicks":0,"LowQualityConversions":0,"LowQualityConversionRate":null,"Revenue":0.0,"RevenuePerConversion":null,"RevenuePerAssist":null},"emitted_at":1704833285214}
+{"stream":"account_performance_report_daily","data":{"AccountId":180519267,"TimePeriod":"2024-02-19","CurrencyCode":"USD","AdDistribution":"Search","DeviceType":"Computer","Network":"Syndicated search partners","DeliveredMatchType":"Exact","DeviceOS":"Windows","TopVsOther":"Syndicated search partners - Top","BidMatchType":"Broad","AccountName":"Airbyte","AccountNumber":"F149MJ18","PhoneImpressions":0,"PhoneCalls":0,"Clicks":0,"Ctr":0.0,"Spend":0.0,"Impressions":1,"CostPerConversion":null,"Ptr":null,"Assists":0,"ReturnOnAdSpend":null,"CostPerAssist":null,"AverageCpc":0.0,"AveragePosition":0.0,"AverageCpm":0.0,"Conversions":0.0,"ConversionsQualified":0.0,"ConversionRate":null,"LowQualityClicks":0,"LowQualityClicksPercent":null,"LowQualityImpressions":0,"LowQualitySophisticatedClicks":0,"LowQualityConversions":0,"LowQualityConversionRate":null,"Revenue":0.0,"RevenuePerConversion":null,"RevenuePerAssist":null},"emitted_at":1704833285214}
 {"stream":"account_performance_report_weekly","data":{"AccountId":180519267,"TimePeriod":"2023-12-17","CurrencyCode":"USD","AdDistribution":"Search","DeviceType":"Computer","Network":"Syndicated search partners","DeliveredMatchType":"Exact","DeviceOS":"Unknown","TopVsOther":"Syndicated search partners - Top","BidMatchType":"Broad","AccountName":"Airbyte","AccountNumber":"F149MJ18","PhoneImpressions":0,"PhoneCalls":0,"Clicks":0,"Ctr":0.0,"Spend":0.0,"Impressions":5,"CostPerConversion":null,"Ptr":null,"Assists":0,"ReturnOnAdSpend":null,"CostPerAssist":null,"AverageCpc":0.0,"AveragePosition":0.0,"AverageCpm":0.0,"Conversions":0.0,"ConversionsQualified":0.0,"ConversionRate":null,"LowQualityClicks":0,"LowQualityClicksPercent":null,"LowQualityImpressions":4,"LowQualitySophisticatedClicks":0,"LowQualityConversions":0,"LowQualityConversionRate":null,"Revenue":0.0,"RevenuePerConversion":null,"RevenuePerAssist":null},"emitted_at":1704833307364}
 {"stream":"ad_group_performance_report_daily","data":{"AccountId":180519267,"CampaignId":531016227,"AdGroupId":1356799861840328,"TimePeriod":"2023-12-18","CurrencyCode":"USD","AdDistribution":"Search","DeviceType":"Computer","Network":"Microsoft sites and select traffic","DeliveredMatchType":"Exact","DeviceOS":"Windows","TopVsOther":"Microsoft sites and select traffic - top","BidMatchType":"Broad","Language":"Portuguese","AccountName":"Airbyte","CampaignName":"Airbyte test","CampaignType":"Search & content","AdGroupName":"keywords","AdGroupType":"Standard","Impressions":2,"Clicks":1,"Ctr":50.0,"Spend":0.01,"CostPerConversion":null,"QualityScore":7.0,"ExpectedCtr":"2","AdRelevance":3.0,"LandingPageExperience":2.0,"PhoneImpressions":0,"PhoneCalls":0,"Ptr":null,"Assists":0,"CostPerAssist":null,"CustomParameters":null,"FinalUrlSuffix":null,"ViewThroughConversions":0,"AllCostPerConversion":null,"AllReturnOnAdSpend":0.0,"AllConversions":0,"AllConversionRate":0.0,"AllRevenue":0.0,"AllRevenuePerConversion":null,"AverageCpc":0.01,"AveragePosition":0.0,"AverageCpm":5.0,"Conversions":0.0,"ConversionRate":0.0,"ConversionsQualified":0.0,"HistoricalQualityScore":6.0,"HistoricalExpectedCtr":2.0,"HistoricalAdRelevance":3.0,"HistoricalLandingPageExperience":2.0,"Revenue":0.0,"RevenuePerConversion":null,"RevenuePerAssist":null},"emitted_at":1704884363801}
 {"stream":"ad_group_performance_report_weekly","data":{"AccountId":180519267,"CampaignId":531016227,"AdGroupId":1356799861840328,"TimePeriod":"2023-12-17","CurrencyCode":"USD","AdDistribution":"Search","DeviceType":"Computer","Network":"Syndicated search partners","DeliveredMatchType":"Exact","DeviceOS":"Unknown","TopVsOther":"Syndicated search partners - Top","BidMatchType":"Broad","Language":"German","AccountName":"Airbyte","CampaignName":"Airbyte test","CampaignType":"Search & content","AdGroupName":"keywords","AdGroupType":"Standard","Impressions":1,"Clicks":0,"Ctr":0.0,"Spend":0.0,"CostPerConversion":null,"QualityScore":7.0,"ExpectedCtr":"2","AdRelevance":3.0,"LandingPageExperience":2.0,"PhoneImpressions":0,"PhoneCalls":0,"Ptr":null,"Assists":0,"CostPerAssist":null,"CustomParameters":null,"FinalUrlSuffix":null,"ViewThroughConversions":0,"AllCostPerConversion":null,"AllReturnOnAdSpend":null,"AllConversions":0,"AllConversionRate":null,"AllRevenue":0.0,"AllRevenuePerConversion":null,"AverageCpc":0.0,"AveragePosition":0.0,"AverageCpm":0.0,"Conversions":0.0,"ConversionRate":null,"ConversionsQualified":0.0,"HistoricalQualityScore":6.0,"HistoricalExpectedCtr":2.0,"HistoricalAdRelevance":3.0,"HistoricalLandingPageExperience":2.0,"Revenue":0.0,"RevenuePerConversion":null,"RevenuePerAssist":null},"emitted_at":1704833349472}