Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stick Visualizer #579

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Stick Visualizer #579

wants to merge 21 commits into from

Conversation

GreemDev
Copy link
Member

It works, but I'm not sure how I feel about not having the controller image.

@github-actions github-actions bot added the gui Affects the Avalonia UI or translations. label Jan 25, 2025
@usr20210909
Copy link

The way it's done in #533 is looking nice - the sticks are moving in the controller image.

@GreemDev
Copy link
Member Author

The way it's done in #533 is looking nice - the sticks are moving in the controller image.

The SDL3 PR (when it comes) is not going to include that functionality.
That is way outside of the scope of a dependency update PR.

@GabCoolDude
Copy link
Collaborator

When comparing to #533, this looks bland without the controller image, we already use the joy con image in other places, like the controller pop-up, so i don't see a reason to not use it.

@GreemDev
Copy link
Member Author

GreemDev commented Feb 5, 2025

Because those images are just basic controller images incapable of moving.
Why did that SDL3 PR have to give people a false sense of hope 🙄

@GabCoolDude
Copy link
Collaborator

I never mentioned anything about moving the controller, that would not only be a major pain to implement, but even then you'd have to put a lot of effort into it, for something not very important. All i'm asking is for a controller image where the button you pressed lights up and the joysticks move.

@GreemDev
Copy link
Member Author

GreemDev commented Feb 5, 2025

I never mentioned anything about moving the controller, that would not only be a major pain to implement, but even then you'd have to put a lot of effort into it, for something not very important. All i'm asking is for a controller image where the button you pressed lights up and the joysticks move.

Gab you do realize we need to add in a way for a static image to animate to do this right

@GabCoolDude
Copy link
Collaborator

🤷

@Ryubing Ryubing deleted a comment from usr20210909 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants