Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom configuration for each game #632

Open
wants to merge 52 commits into
base: master
Choose a base branch
from
Open

Conversation

Goodfeat
Copy link
Contributor

@Goodfeat Goodfeat commented Feb 6, 2025

image

image

Now you can make a separate configuration (independent file) for each game. All emulator settings are available except for control. The configuration file can be changed and deleted from a separate menu. The user configuration menu is available through the context menu

Pull request is in beta. may require revision

@github-actions github-actions bot added gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components. infra Updates to dependencies labels Feb 6, 2025
.github/workflows/release.yml Outdated Show resolved Hide resolved
src/Ryujinx/Program.cs Outdated Show resolved Hide resolved
src/Ryujinx/UI/Controls/ApplicationContextMenu.axaml Outdated Show resolved Hide resolved
src/Ryujinx/UI/Controls/ApplicationGridView.axaml Outdated Show resolved Hide resolved
@Goodfeat
Copy link
Contributor Author

Goodfeat commented Feb 7, 2025

Gamepad settings added for user config
image

@LotP1
Copy link
Contributor

LotP1 commented Feb 7, 2025

could the game title be added to the settings window title if it's a game specific configuration?
e.g. Ryujinx 1.2.x - Settings - The Legend of Zelda: Tears of the Kingdom

@Goodfeat
Copy link
Contributor Author

Goodfeat commented Feb 8, 2025

could the game title be added to the settings window title if it's a game specific configuration?

Yes, no problem.

image

@Ryubing Ryubing deleted a comment from Goodfeat Feb 8, 2025
@LotP1
Copy link
Contributor

LotP1 commented Feb 8, 2025

just for your information the bot message with builds auto-updates with new builds after all checks have completed :-)
you do not need to provide your own builds.

@Goodfeat
Copy link
Contributor Author

Goodfeat commented Feb 8, 2025

just for your information the bot message with builds auto-updates with new builds after all checks have completed :-)
you do not need to provide your own builds.

I didn't know, thanks for the information.

…ng the game if it did not exist.

Now when starting the game, if a custom setting was created, the current game will be displayed in the settings window.
Code cleanup.
hotkeys should now also be read from the global configuration file
@MaxLastBreath
Copy link
Contributor

This is looking really good! Looking forward to it.

src/Ryujinx/Program.cs Outdated Show resolved Hide resolved
src/Ryujinx/UI/ViewModels/SettingsViewModel.cs Outdated Show resolved Hide resolved
src/Ryujinx/UI/Windows/UserConfigWindows.axaml Outdated Show resolved Hide resolved
src/Ryujinx/Utilities/AppLibrary/ApplicationData.cs Outdated Show resolved Hide resolved
src/Ryujinx/Utilities/CommandLineState.cs Outdated Show resolved Hide resolved
@Goodfeat
Copy link
Contributor Author

At this stage, this pull request is working, if you run future builds without this function, then other builds do not crash, that is, emulator builds are compatible with each other

  • Loading and saving the game with and without a custom configuration have been tested.

  • The functions of saving, changing and deleting a custom configuration do not affect the global config in any way.

  • Some settings from the global configuration will not work for the custom configuration (in particular, functions from the user interface, theme, game directory, etc. for obvious reasons).

  • The emulator will automatically restart with the selected game when using the custom configurator, if the "graphics multithread" setting has been changed and differs from the global one.

  • The custom setting can be removed from the "Edit Game Configuration" context menu before loading the game.

@GreemDev GreemDev dismissed their stale review February 14, 2025 01:50

Changes implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gui Affects the Avalonia UI or translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants