-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement VoxelArea #84
base: master
Are you sure you want to change the base?
Conversation
I realized that that part of the code was similar to Minetest's implementation, and not coincidentally so. I don't want to get into trouble.
5e30682
to
810b404
Compare
810b404
to
5989fdb
Compare
Implementation has to be moved to root directory. Reason why this cannot be in game directory is because it is not coming from core engine lua scripts. |
Perhaps you could just copy the implementation from Minetest and put it in the game/ directory. |
Actually I think It'll be available if you run Mineunit with full Minetest core libraries using for example
Everything around engine core libs is just badly messed up... that's mostly because it was not planned in any way and added on top of messed up directory structure. See this crap for example: Lines 52 to 71 in db70bcd
Engine core library management requires some serious refactoring and I've planned to do that at some point in future but probably before that I have to refactor another completely messed up thing which is current Mineunit configuration system. |
Tested VoxelArea using --engine-version 5.4.1 mt-mods/technic@385ce5b
However that's not really fixing whole issue as core library version management is still terrible. |
I suppose it depends on the license of Minetest's implementation. |
LGPL 2.1 which is fine and already included here too https://github.com/S-S-X/mineunit/blob/master/LICENSE because there's few libraries included as is without changes directly from Minetest. |
Closes #34.
This is an independent VoxelArea implementation. There are tests.