-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
91cd24c
commit c5c8046
Showing
2 changed files
with
46 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
# Export of parquet files and DICOM data | ||
|
||
* Status: accepted | ||
* Deciders: Haroon Chughtai, Jeremy Stein, Milan Malfait, Ruaridh Gollifer, Stef Piatek | ||
* Date: 2024-02-26 | ||
|
||
## Context and Problem Statement | ||
|
||
The pipeline needs to be able to export DICOM images and structured data files to different endpoints. | ||
|
||
## Decision Drivers <!-- optional --> | ||
|
||
* We expect that some projects will have more data than we can store locally. Will need a rolling export of images | ||
* We will need to be able to export images and structured data via FTPS in an automated fashion | ||
* We will need to be able to export images via DICOMWeb | ||
|
||
|
||
## Considered Options | ||
|
||
* Shared python library for exporting of data, used in `orthanc-anon` and the `pixl` CLI. | ||
* `export-api` service, which can export both DICOM and structured data files. | ||
|
||
## Decision Outcome | ||
|
||
Chosen options: "`export-api` service", for clear separation of responsibilities. | ||
|
||
## Pros and Cons of the Options <!-- optional --> | ||
|
||
### Shared python library | ||
|
||
Add private creator group to instances as they arrive, and a dummy value in the custom tag. | ||
Once the study has been pulled from the DICOM source, update the tag with the filename stem of the project config. | ||
|
||
* Good, one less service to maintain | ||
* Good, export via DICOMWeb is using the orthanc API already | ||
* Bad, duplication of implementation for export | ||
* Bad, duplication of areas where secrets are used | ||
|
||
### `export-api` service | ||
|
||
Instead of shared library the code would be in the service alone. | ||
|
||
* Good, single service that will access all secrets and orchestrate exports | ||
* Good, allows caching of export secrets in a long-running service | ||
* Bad, would require extra code for interacting with the service from the CLI for parquet export |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters