Set orthanc raw maximum storage in Dockerfile #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves us from faffing around with build args for other tests
|
Looks like its working, setting the maximum size to 100 Mb
Studies which had been longest since they were received in orthanc are deleted first 🎉 I think ready for review |
milanmlft
approved these changes
Dec 12, 2023
2 tasks
|
Adding a very simple test in line with the current system tests (just checking the docker logs), but should probably be improved as part of #205 |
5 tasks
milanmlft
added a commit
that referenced
this pull request
Dec 13, 2023
* Fix env variable names in `delete_oldest_n_studies.py` These new variable names are consistent with what is set in `.env` and `test/.env.test` * Add MaximumStorageSize config for orthanc-raw * MaximumStorageSize needs to be an integer * Revert "Fix env variable names in `delete_oldest_n_studies.py`" This reverts commit 0842f43. * Set orthanc raw maximum storage in Dockerfile (#179) * Set orthanc raw maximum storage in Dockerfile * Orthanc raw defaults to no limit on storage Saves us from faffing around with build args for other tests * Format README * Document `ORTHANC_RAW_MAXIMUM_STORAGE_SIZE` * Add simple test for `ORTHANC_RAW_MAXIMUM_STORAGE_SIZE` --------- Co-authored-by: Milan Malfait <[email protected]> --------- Co-authored-by: Milan Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't sure how much time you've spent messing around with docker build arguments so dropping this in as a suggestion for how to set the limit (and hopefully allow us to start off a run this afternoon using this)
Fixes UCLH-Foundry/the-rolling-skeleton#69