Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Python and Orthanc Dockerfiles #583

Merged
merged 11 commits into from
Jan 6, 2025

Conversation

jeremyestein
Copy link
Contributor

@jeremyestein jeremyestein commented Dec 18, 2024

Description

Fixes #588 :

A cut down version of #400 , with just the Dockerfile de-duping. If we decide #400 is too risky to merge now, we can at least merge this one and do the rest of #400 later. The advantage is it enables further work on the Dockerfiles, such as switching to uv.

Type of change

Please delete options accordingly to the description.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Suggested Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have passed on my local host device. (see further details at the CONTRIBUTING document)
  • Make sure your branch is up-to-date with main branch. See CONTRIBUTING for a general example to syncronise your branch with the main branch.
  • I have requested review to this PR.
  • I have addressed and marked as resolved all the review comments in my PR.
  • Finally, I have selected squash and merge

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (208e74c) to head (b1aa5f8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #583   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          76       76           
  Lines        3380     3380           
=======================================
  Hits         2949     2949           
  Misses        431      431           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeremyestein jeremyestein marked this pull request as ready for review December 18, 2024 18:01
Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking really nice - just a question around downloading the DICOM spec for Orthanc Anon

docker/orthanc/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will leave it to you and Paul to work out the best way to have the python spec downloaded and cached

docker/orthanc/Dockerfile Show resolved Hide resolved
@jeremyestein jeremyestein merged commit 807f84b into main Jan 6, 2025
11 checks passed
@jeremyestein jeremyestein deleted the jeremy/refactor-dockerfiles branch January 6, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce repetition by refactoring dockerfiles
3 participants