Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear when study already exported #585

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

stefpiatek
Copy link
Contributor

Also reworked test setup so there's a bit less duplication, and added in tests

@stefpiatek stefpiatek requested a review from p-j-smith December 27, 2024 15:47
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.41%. Comparing base (b3921b6) to head (4fdbaac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   83.28%   87.41%   +4.12%     
==========================================
  Files          68       76       +8     
  Lines        3070     3425     +355     
==========================================
+ Hits         2557     2994     +437     
+ Misses        513      431      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! And nice refactor of the tests. Very minor suggestion, feel free to ignore

pixl_dcmd/src/pixl_dcmd/_database.py Outdated Show resolved Hide resolved
@stefpiatek stefpiatek enabled auto-merge (squash) January 13, 2025 14:40
@stefpiatek stefpiatek merged commit dca65ca into main Jan 14, 2025
11 checks passed
@stefpiatek stefpiatek deleted the stefpiatek/exported_image_info branch January 14, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants