Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep value_as_concept_id in the summary stats table #122

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

milanmlft
Copy link
Member

  • Fixes currently failing tests due to an out-of-date snapshot
  • Gets rid of warnings due to duplicate rows in the summary_stats table in the test and dev data

The duplicate rows in this case were due to some of the value_as_concept_id values not having a match in the concepts table of the test database, resulting in NA values for the value_as_string column. Which in turn leads to duplicate rows as the two rows now both have NA as value_as_string even though the original value_as_concept_id was different. Keeping the column in seems sensible and gets rid of the warnings in the tests.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (24b0f51) to head (ab077b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
- Coverage   94.36%   93.70%   -0.66%     
==========================================
  Files          23       23              
  Lines         763      763              
==========================================
- Hits          720      715       -5     
- Misses         43       48       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milanmlft milanmlft changed the title Keep value_as_concept_id in the summary stats table fix: Keep value_as_concept_id in the summary stats table Jan 22, 2025
@milanmlft milanmlft merged commit ba46c7d into main Jan 22, 2025
8 checks passed
@milanmlft milanmlft deleted the milanmlft/fix-test-data branch January 22, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant