Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dashboard reactive to concept selection #31

Merged
merged 32 commits into from
Aug 20, 2024
Merged

Make dashboard reactive to concept selection #31

merged 32 commits into from
Aug 20, 2024

Conversation

milanmlft
Copy link
Member

The summary plots are now reactive to the selected concept from the overview datatable.

  • Added data getters to import data based on format defined in Summary statistics #22
  • Added reactive elements to the relevant modules
  • Added basic unit tests to test reactivity
  • Additional tests for the helper functions that create the plots

Fixes #13

milanmlft added 30 commits August 16, 2024 18:15
@milanmlft
Make plots reactive to the selected row in datatable
2feb18f
@milanmlft
Add asserts for monthly count plot
0279965
@milanmlft
Only show plots when row is selected
7c01b96
@milanmlft
Add data getters with temporary dummy data
424943f
@milanmlft
Add basic unit tests for datatable module
3282818
@milanmlft
Test that concepts selection works
b8af74c
@milanmlft
Use data getters in app logic
b7849c3
@milanmlft
Small refactor; remove spurious id suffixes
5f05bc8
@milanmlft
Adapt monthly_count plot to use correct column names
2261888
@milanmlft
Move data filtering to the main server logic for now
69d6cbb
@milanmlft
Slight refactor of monthly_count_plot()
d8e82c5
@milanmlft
Add note for stat_numeric_plot()
6cdfed5
@milanmlft
Assume data filtering has already happened for plot modules
39948c1
@milanmlft
Add note about module structure
4f08746
@milanmlft
Test that stat_numeric_plot processes data correctly
b3dff77
@milanmlft
Format data for numeric stats boxplot
9095d19
@milanmlft
Update tests
d112a79
@milanmlft
Check for expected column names
fe75a3b
@milanmlft
Typo fix: attribbute -> attribute
be82d81
@milanmlft
Move empty plot logic to module servers instead of plotting functions
1b3bcce
@milanmlft
Update docs
5d11bfb
@milanmlft
Ignore .renvignore for package builds
515c44c
@milanmlft
Add withr to Imports
329362b
@milanmlft
Move helper function tests to module-level tests
9fc5b9d
@milanmlft
Add concept name as plot title for numeric stats plot
85bb7cf
@milanmlft
Move data filtering back into modules
258dea2
@milanmlft
Add reactivity tests for numeric stats plot
5a7a30d
@milanmlft
Move data loading back to main server and have data argument for modules
25db523
@milanmlft
Add reactivity tests for monthly counts module
04248fe
@milanmlft
Test monthly count plot helper
91cee11
@milanmlft milanmlft requested a review from a team August 19, 2024 17:07
stefpiatek
stefpiatek approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

R/fct_stat_numeric_plot.R Show resolved Hide resolved
@milanmlft milanmlft merged commit 43d0c9c into main Aug 20, 2024
2 checks passed
@milanmlft milanmlft deleted the milanmlft/add-reactivity branch August 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefpiatek stefpiatek stefpiatek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make dashboard outputs reactive to concept selection
2 participants
@milanmlft @stefpiatek