Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary stat plot for categorical concepts #36

Merged
merged 20 commits into from
Aug 27, 2024

Conversation

milanmlft
Copy link
Member

@milanmlft milanmlft commented Aug 22, 2024

Follow-up from #12 and #32, realised we didn't have the plot yet for categorical concepts 🙃

Using some dummy date, the plot should look like this:

  mock_stats <- data.frame(
    concept_id = rep(1234567, 3),
    summary_attribute = rep("frequency", 3),
    value_as_string = paste0("cat_", seq(3)),
    value_as_number = c(42, 23, 68)
  )

summary_stat_plot(mock_stats, plot_title = "test")

I chose to order the bars by frequency (which is why cat_3 is appearing as the first), but that's just an aesthetic detail, happy to change :)

image

@milanmlft milanmlft requested a review from a team August 22, 2024 14:50
Copy link
Contributor

@stefpiatek stefpiatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,thanks Milan

@milanmlft milanmlft enabled auto-merge (squash) August 27, 2024 13:30
@milanmlft milanmlft merged commit ff8d57f into main Aug 27, 2024
2 checks passed
@milanmlft milanmlft deleted the milanmlft/categorical-stats-plot branch August 27, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants