Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master: Fix tests on Windows, add Ruby 3.3, and cleanup CI #687

Merged

Conversation

johnnyshields
Copy link
Collaborator

On Windows, the DateTime class struggles with Float values for certain methods like #next_year some reason.

@johnnyshields johnnyshields force-pushed the master-fix-tests-windows branch 2 times, most recently from 99ec80d to 27d6c02 Compare July 8, 2024 12:48
@johnnyshields
Copy link
Collaborator Author

johnnyshields commented Jul 8, 2024

@pitbulk this is ready to be merged.

The JRuby Zlib::BufError failures are transient and can be ignored.

@johnnyshields johnnyshields changed the title Master: Fix tests on Windows and cleanup CI Master: Fix tests on Windows, add Ruby 3.3, and cleanup CI Jul 8, 2024
@johnnyshields
Copy link
Collaborator Author

@pitbulk this can be merged independently of the other PRs.

@pitbulk
Copy link
Collaborator

pitbulk commented Jul 8, 2024

This PR has a mix of the code to be sent to V2 and the one to master branch

See https://github.com/SAML-Toolkits/ruby-saml/pull/687/files#diff-d57c932f52c1cf52ca2f9028672cc7d038bf9c8200484ddc80e63a212a68e6b3

@johnnyshields
Copy link
Collaborator Author

@pitbulk oops! Sorry about that, its now fixed and ready to merge.

@pitbulk pitbulk merged commit 6e33ed3 into SAML-Toolkits:master Jul 9, 2024
35 of 36 checks passed
@pitbulk
Copy link
Collaborator

pitbulk commented Jul 9, 2024

@johnnyshields, We should also apply this on V2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants