Release 2.0.4

CHANGES

@@ -1,6 +1,12 @@
 Change log
 ==========
 
+2.0.4 (2020-03-17)
+------------------
+- locale method fix for Python 3.8.2 on Windows
+- NWRFCSDK include path fix for Linux
+- README
+
 2.0.3 (2020-03-16)
 ------------------
 - PyPI package pynwrfc

README.md

@@ -1,11 +1,9 @@
-# SAP NW RFC SDK Client for Python
-
 Asynchronous, non-blocking [SAP NetWeawer RFC SDK](https://support.sap.com/en/products/connectors/nwrfcsdk.html) client bindings for Python.
 
 [![license](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
-![PyPI - Wheel](https://img.shields.io/pypi/wheel/pynwrfc)
-![PyPI - Implementation](https://img.shields.io/pypi/implementation/pynwrfc)
-![PyPI - Python Version](https://img.shields.io/pypi/pyversions/pynwrfc)
+[![PyPI - Wheel](https://img.shields.io/pypi/wheel/pynwrfc)](https://pypi.org/project/pynwrfc/)
+[![PyPI - Implementation](https://img.shields.io/pypi/implementation/pynwrfc)](https://pypi.org/project/pynwrfc/)
+[![PyPI - Python Version](https://img.shields.io/pypi/pyversions/pynwrfc)](https://pypi.org/project/pynwrfc/)
 [![PyPI - Downloads](https://img.shields.io/pypi/dm/pynwrfc)](https://pypistats.org/packages/pynwrfc)
 
 ## Features
@@ -21,10 +19,12 @@ Asynchronous, non-blocking [SAP NetWeawer RFC SDK](https://support.sap.com/en/pr
 
 - Pre-built wheels are provided for Windows 10 and macOS 10.15
 
-- Linux platforms are supported by build from source installation only (see **[Installation](#Installation)** section below). Portable Linux wheels must not be distributed with embedded SAP NWRFC SDK binaries, only private use permitted.
+- Linux platforms are supported by build from source installation only (see **[Installation](#Installation)** section below).
 
 - Pre-built [portable Linux wheels](https://www.python.org/dev/peps/pep-0513/) are not supported, neither issues related to portable Linux wheels
 
+- Pre-built portable Linux wheels must not be distributed with embedded SAP NWRFC SDK binaries, only private use permitted
+
 - [Build from source](http://sap.github.io/PyRFC/build.html) is supported on all [platforms supported by SAP NW RFC SDK](https://launchpad.support.sap.com/#/notes/2573790).
 
 ## Prerequisites
@@ -37,7 +37,7 @@ Asynchronous, non-blocking [SAP NetWeawer RFC SDK](https://support.sap.com/en/pr
 
 ### Windows
 
-- Visual C++ Redistributable is required for runtime. The version is given in [SAP Note 2573790 - Installation, Support and Availability of the SAP NetWeaver RFC Library 7.50](https://launchpad.support.sap.com/#/notes/2573790)
+- [Visual C++ Redistributable](https://www.microsoft.com/en-US/download/details.aspx?id=40784) is required for runtime. The version is given in [SAP Note 2573790 - Installation, Support and Availability of the SAP NetWeaver RFC Library 7.50](https://launchpad.support.sap.com/#/notes/2573790)
 
 - Build toolchain for Python 3 requires [Microsoft C++ Build Tools](https://aka.ms/buildtools), the latest version reccomended
 

VERSION

@@ -1 +1 @@
-2.0.3
+2.0.4

setup.py

@@ -62,7 +62,7 @@
         "-fPIC",
         "-pthread",
         "-minline-all-stringops",
-        "-I{}\\include".format(SAPNWRFC_HOME),
+        "-I{}/include".format(SAPNWRFC_HOME),
     ]
     LINK_ARGS = ["-L{}/lib".format(SAPNWRFC_HOME)]
 elif sys.platform.startswith("win"):

src/pyrfc/__init__.py

@@ -45,4 +45,4 @@
 
 __author__ = """"Srdjan Boskovic"""
 __email__ = "[email protected]"
-__version__ = "2.0.3"
+__version__ = "2.0.4"

tests/test_datatypes.py

@@ -129,6 +129,19 @@ def test_string_unicode():
     result = client.call("STFC_CONNECTION", REQUTEXT=hello)["ECHOTEXT"]
     assert result == hello
 
+    unicode_test = [
+        "string",
+        "四周远处都能望见",
+        "\U0001F4AA",
+        "\u0001\uf4aa",
+        "a\xac\u1234\u20ac\U0001F4AA",
+    ]
+
+    for s in unicode_test:
+        is_input = {"ZSHLP_MAT1": s}
+        result = client.call("/COE/RBP_FE_DATATYPES", IS_INPUT=is_input)["ES_OUTPUT"]
+        assert is_input["ZSHLP_MAT1"] == result["ZSHLP_MAT1"]
+
 
 def test_date_output():
     lm = client.call("BAPI_USER_GET_DETAIL", USERNAME="demo")["LASTMODIFIED"]
@@ -622,7 +635,7 @@ def test_float_accepts_point_for_point_locale():
 
 
 def test_float_rejects_point_for_comma_locale():
-    locale.setlocale(locale.LC_ALL, "de_DE.UTF-8")
+    locale.setlocale(locale.LC_ALL, "de_DE")
     IMPORTSTRUCT = {"RFCFLOAT": "1.2"}
     try:
         output = client.call("STFC_STRUCTURE", IMPORTSTRUCT=IMPORTSTRUCT)
@@ -638,7 +651,7 @@ def test_float_rejects_point_for_comma_locale():
 
 
 def test_float_accepts_comma_for_comma_locale():
-    locale.setlocale(locale.LC_ALL, "de_DE.UTF-8")
+    locale.setlocale(locale.LC_ALL, "de_DE")
     IMPORTSTRUCT = {"RFCFLOAT": "1,2"}
     output = client.call("STFC_STRUCTURE", IMPORTSTRUCT=IMPORTSTRUCT)["ECHOSTRUCT"]
     assert output["RFCFLOAT"] == 1.2