Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight size-based deletion in service plan description #7

Closed
wants to merge 1 commit into from
Closed

Highlight size-based deletion in service plan description #7

wants to merge 1 commit into from

Conversation

juergen-walter
Copy link
Contributor

formatting change only

@juergen-walter
Copy link
Contributor Author

Should look the same as https://help.sap.com/docs/cloud-logging/cloud-logging/ingest-via-kyma-runtime?version=Cloud

@juergen-walter
Copy link
Contributor Author

image

@pc-jedi pc-jedi requested a review from keyes-bill May 7, 2024 08:00
pc-jedi
pc-jedi approved these changes May 7, 2024
View reviewed changes
Copy link

@pc-jedi pc-jedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

LGTM, but waiting for @keyes-bill review.

@williamkeyes
Copy link

I've made the changes to the DRAFT version of the documentation.
https://help.sap.com/docs/cloud-logging/sap-cloud-logging/service-plans?state=DRAFT

@juergen-walter
Copy link
Contributor Author

Looks good 👍

@williamkeyes
Copy link

I've pushed this out to PROD. Should be available within a few hours of this writing.

williamkeyes
williamkeyes approved these changes May 8, 2024
View reviewed changes
Copy link

@williamkeyes williamkeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the changes as requested and pushed out to PROD. Should be available Wed or Thurs May 8-9.

@pc-jedi pc-jedi removed the request for review from keyes-bill May 17, 2024 08:09
@je-hal
Copy link

je-hal commented Jul 1, 2024

@keyes-bill : This looks to me as if it was a valuable contribution. Please be reminded to do the following in such cases:

  1. use label contribution.
  2. Use one of the type/ labels.
  3. Merge the pull request. Closing pull requests means you rejected the change and contributors won't get any credits for it.

Thanks

@vilijana vilijana added contribution Valuable Contribution and removed contribution Valuable Contribution labels Oct 2, 2024
@keyes-bill keyes-bill added contribution Valuable Contribution size/s Requires minimal effort to get changed. type/content-structure The documentation structure needs to be improved. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamkeyes williamkeyes williamkeyes approved these changes

@pc-jedi pc-jedi pc-jedi approved these changes

Assignees
No one assigned
Labels
contribution Valuable Contribution size/s Requires minimal effort to get changed. type/content-structure The documentation structure needs to be improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juergen-walter @williamkeyes @je-hal @pc-jedi @vilijana @keyes-bill