Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy-paste error and improve formatting #9

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix copy-paste error and improve formatting #9

merged 2 commits into from
Jul 31, 2024

Conversation

juergen-walter
Copy link
Contributor

No description provided.

@williamkeyes
Copy link

I've fixed these in the DRAFT version: https://help.sap.com/docs/cloud-logging/sap-cloud-logging/configuration-parameters?state=DRAFT
It should show up in the next nightly build.

@williamkeyes
Copy link

This is fixed in the DRAFT version. If it looks good, I'll push it out to PROD.
https://help.sap.com/docs/cloud-logging/sap-cloud-logging/configuration-parameters?state=DRAFT

@juergen-walter
Copy link
Contributor Author

Push it to prod please

@williamkeyes
Copy link

Thanks, @juergen-walter. I have pushed the changes out to PROD. They should show up after the next build.

@juergen-walter
Copy link
Contributor Author

Fix is still not available here: https://help.sap.com/docs/cloud-logging/cloud-logging/configuration-parameters?version=Cloud ....

@juergen-walter
Copy link
Contributor Author

I would assume it is propagated after merge, right?

williamkeyes
williamkeyes approved these changes Jul 29, 2024
View reviewed changes
Copy link

@williamkeyes williamkeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamkeyes
Copy link

PROD builds are done weekly, usually on either Wednesday or Thursday. So the changes should show up in PROD later in the week. I apologize I wasn't more clear on this earlier.

@williamkeyes
Copy link

The changes are now available in PROD
https://help.sap.com/docs/cloud-logging/sap-cloud-logging/configuration-parameters

keyes-bill
keyes-bill approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@keyes-bill keyes-bill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyes-bill keyes-bill merged commit 83bb97e into SAP-docs:main Jul 31, 2024
2 checks passed
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Jul 31, 2024
@juergen-walter juergen-walter deleted the patch-4 branch August 5, 2024 09:23
@keyes-bill keyes-bill added size/m Requires medium effort to get changed. type/clarity Something was unclear in the documentation. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyes-bill keyes-bill keyes-bill approved these changes

@williamkeyes williamkeyes williamkeyes approved these changes

Assignees
No one assigned
Labels
contribution Valuable Contribution size/m Requires medium effort to get changed. type/clarity Something was unclear in the documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juergen-walter @williamkeyes @keyes-bill