-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to UI5 version 1.132.1 #96
Conversation
matz3
commented
Dec 17, 2024
•
edited by flovogt
Loading
edited by flovogt
- Upgrade UI5 version to 1.132.1
- Upgrade minVersion of UI5 to 1.132
- Upgrade @types/openui5 to 1.132.0 (Currently, for @types/openui5 no patch releases are created)
steps/05/package.json
Outdated
@@ -8,7 +8,7 @@ | |||
"start": "ui5 serve -o index.html" | |||
}, | |||
"devDependencies": { | |||
"@types/openui5": "^1.120.0", | |||
"@types/openui5": "^1.131.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flovogt no, for @types/openui5, the release process is manual and quite some effort, so we do in general not release any patches. Only in rare exceptions.
For @openui5/types, on the other hand, the types are released ALWAYS as part of the release process, regardless of any changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akudev. I am in favour of migrating the project to @openui5/types
. Then its also easier to switch to the @sapui5/types
. Whats your opinion? @akudev @petermuessig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@openui5/types require a slightly more difficult setup as they are not in the @types standard package, so they need to be mentioned explicitly in tsconfig, but apart from that there is no reason not to do it.
Many readers of the walkthrough will anyway need the @sapui5/types, which are not available in @types, so they will need to apply the more complex setup anyway.
69c9732
to
274594f
Compare
274594f
to
be05464
Compare
I have updated the PR to reflect the usage of the current latest UI5 version. The migration of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In step 01, readme you are still using the outdated term "app descriptor". Also the manifest is not updated to 1.68 as explained in the text.
- Upgrade UI5 version to 1.132.1 - Upgrade minVersion of UI5 to 1.132 - Upgrade @types/openui5 to 1.132.0 (Currently, for @types/openui5 no patch releases are created)
be05464
to
bfc8b4f
Compare