Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to UI5 version 1.132.1 #96

Merged
merged 2 commits into from
Feb 10, 2025
Merged

chore: update to UI5 version 1.132.1 #96

merged 2 commits into from
Feb 10, 2025

Conversation

matz3
Copy link
Contributor

@matz3 matz3 commented Dec 17, 2024

  • Upgrade UI5 version to 1.132.1
  • Upgrade minVersion of UI5 to 1.132
  • Upgrade @types/openui5 to 1.132.0 (Currently, for @types/openui5 no patch releases are created)

@@ -8,7 +8,7 @@
"start": "ui5 serve -o index.html"
},
"devDependencies": {
"@types/openui5": "^1.120.0",
"@types/openui5": "^1.131.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matz3 @akudev There is a openui5 version 1.131.1 but no patch release for the types. So this means, there were no change in regards to types, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flovogt no, for @types/openui5, the release process is manual and quite some effort, so we do in general not release any patches. Only in rare exceptions.
For @openui5/types, on the other hand, the types are released ALWAYS as part of the release process, regardless of any changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akudev. I am in favour of migrating the project to @openui5/types . Then its also easier to switch to the @sapui5/types. Whats your opinion? @akudev @petermuessig

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openui5/types require a slightly more difficult setup as they are not in the @types standard package, so they need to be mentioned explicitly in tsconfig, but apart from that there is no reason not to do it.
Many readers of the walkthrough will anyway need the @sapui5/types, which are not available in @types, so they will need to apply the more complex setup anyway.

@flovogt flovogt changed the title chore: update to UI5 version 1.131.1 chore: update to UI5 version 1.132.1 Feb 10, 2025
@flovogt
Copy link
Member

flovogt commented Feb 10, 2025

I have updated the PR to reflect the usage of the current latest UI5 version.

The migration of @types/openui5 to @openui5/types will be done in a separate PR

akudev
akudev previously approved these changes Feb 10, 2025
steps/01/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@margopolo margopolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In step 01, readme you are still using the outdated term "app descriptor". Also the manifest is not updated to 1.68 as explained in the text.

@akudev akudev self-requested a review February 10, 2025 13:58
- Upgrade UI5 version to 1.132.1
- Upgrade minVersion of UI5 to 1.132
- Upgrade @types/openui5 to 1.132.0 (Currently, for @types/openui5 no patch releases are created)
@flovogt flovogt requested a review from margopolo February 10, 2025 14:36
@flovogt flovogt merged commit a08c5ce into main Feb 10, 2025
3 checks passed
@flovogt flovogt deleted the upgrade-1.131.1 branch February 10, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants