Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SapMachine (21) #1670: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set #1697

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 17, 2024

Backport to sapmachine21.

fixes #1670

@SapMachine
Copy link
Member

Hello @MBaesken, this pull request fulfills all formal requirements.

1 similar comment
@SapMachine
Copy link
Member

Hello @MBaesken, this pull request fulfills all formal requirements.

Copy link
Member

@ansteiner ansteiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RealCLanger
Copy link
Member

Let's hold this back for a while, I'm trying to create a variant for SapMachine with less diff in #1698.

@RealCLanger RealCLanger changed the title jcmd GC.heap_dump without options should write to location given by -… SapMachine (21) #1670: jcmd GC.heap_dump without options should write to location given by -XX:HeapDumpPath, if set Jun 20, 2024
@RealCLanger RealCLanger force-pushed the my-heapdumppath-jcmd21 branch from a53e82c to 8741e34 Compare June 20, 2024 14:54
@SapMachine
Copy link
Member

Hello @MBaesken, this pull request fulfills all formal requirements.

@SapMachine
Copy link
Member

Hello @MBaesken, this pull request fulfills all formal requirements.

@RealCLanger RealCLanger merged commit 7164451 into sapmachine21 Jun 21, 2024
117 checks passed
@RealCLanger RealCLanger deleted the my-heapdumppath-jcmd21 branch June 21, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants