Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Helm - Use secretRef in gardener certificate #119

Merged
merged 1 commit into from
Feb 24, 2025
Merged

[Fix] Helm - Use secretRef in gardener certificate #119

merged 1 commit into from
Feb 24, 2025

Conversation

anirudhprasad-sap
Copy link
Contributor

@anirudhprasad-sap anirudhprasad-sap commented Feb 21, 2025 •
edited
Loading

Use secretRef.name instead of secretName in gardener certificate

Gardener issue - gardener/cert-management#423

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anirudhprasad-sap anirudhprasad-sap marked this pull request as ready for review February 24, 2025 11:16
Pavan-SAP
Pavan-SAP approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@Pavan-SAP Pavan-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@anirudhprasad-sap anirudhprasad-sap merged commit a9a58c2 into main Feb 24, 2025
8 checks passed
@anirudhprasad-sap anirudhprasad-sap deleted the gardenerCertFix branch February 24, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pavan-SAP Pavan-SAP Pavan-SAP approved these changes

@skrishnan-sap skrishnan-sap Awaiting requested review from skrishnan-sap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anirudhprasad-sap @Pavan-SAP