fix(core): popover escape key to close should not bubble to dialog #12957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit bb7414e): https://fundamental-ngx-gh--pr12957-fix-12605-0iamnfpw.web.app (expires Fri, 31 Jan 2025 16:04:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
mikerodonnell89
changed the title
mikerodonnell89
force-pushed
the
fix/12605
branch
from
653f90c to
a79630a
Compare
|
The popover works well but I've noticed that the multi-input and the multi-combobox now act differently on escape. After navigating in the multi-combobox items with the arrows, you have to press escape twice before closing it completely. Was that intentional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12605
The entire popover should have a keydown escape handler to close the popover body. Also, multi-input/multi-combobox/combobox all had their own escape key handlers for closing their popovers, resulting in the popover service close function being called twice due to the popover now handling this itself