Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): fixed for Input Group, Select and Step Input after design review #4646

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Closes none

Description

Updated components:

  • Select
  • Input Group
  • Step Input

Visual Changes

SELECT
Before:
The arrow is blue, should be black
Screenshot 2023-06-28 at 4 45 22 PM

All states (hover, active, focus, expanded) for the semantic Selects have been updated
Screenshot 2023-06-28 at 4 46 55 PM

Mobile mode. The Dialog header was built with Bar component and the text was not centered vertically.

Screenshot 2023-06-28 at 4 48 36 PM

After:
updated colors for the arrow, placeholder text is italic and gray
Screenshot 2023-06-28 at 4 45 28 PM

Updates states:
Screenshot 2023-06-28 at 4 48 06 PM

Mobile mode. Dialog header uses Toolbar per specs. This is a BREAKING CHANGE.
Screenshot 2023-06-28 at 4 48 41 PM

STEP INPUT:

  • updated the width of the buttons
  • Read-only on focus should preserve the background. The input paddings should be bigger
    Before:
Screenshot 2023-06-28 at 4 52 12 PM

After:
Screenshot 2023-06-28 at 4 52 18 PM

INPUT GROUP:
Similar to Select all states have been updated

BREAKING CHANGE:
The Dialog header used in Mobile Select now uses Toolbar, not Bar component

Before:

...
<div class="fd-dialog__content fd-dialog__content--mobile">
        <header class="fd-dialog__header fd-bar fd-bar--header-with-subheader">
            <div class="fd-bar__left">
                <div class="fd-bar__element">
                    <h3 id="mobileHeader" class="fd-dialog__title">
                        <span class="fd-select__text-content">Select Ingredient</span>
                    </h3>
                </div>
            </div>
            <div class="fd-bar__right">
                <div class="fd-bar__element">
                    <button tabindex="-1" class="fd-button fd-button--transparent" aria-label="close">
                        <i class="sap-icon--decline"></i>
                    </button>
                </div>
            </div>
        </header>
</div>
....

After:

...
<div class="fd-dialog__content fd-dialog__content--mobile">
        <header class="fd-dialog__header fd-toolbar fd-toolbar--clear">
            <span class="fd-select__text-content">Select Ingredient</span>
            <span class="fd-toolbar__spacer"></span>
            <button tabindex="-1" class="fd-button fd-button--transparent" aria-label="close">
                <i class="sap-icon--decline"></i>
            </button>
        </header>
</div>
....

@InnaAtanasova InnaAtanasova added Bug Something isn't working design review changes labels Jun 28, 2023
@InnaAtanasova InnaAtanasova added this to the Sprint 116 milestone Jun 28, 2023
@InnaAtanasova InnaAtanasova requested a review from a team June 28, 2023 20:58
@InnaAtanasova InnaAtanasova self-assigned this Jun 28, 2023
@netlify
Copy link

netlify bot commented Jun 28, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 41c8c5a
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/649c9ef56360030008d60503
😎 Deploy Preview https://deploy-preview-4646--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@droshev droshev merged commit 483df90 into main Jun 30, 2023
8 checks passed
@droshev droshev deleted the fix/input-fields-fixes branch June 30, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working design review changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants