Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(styles): increased bottom margin between interactive elements [ci visual] #4682

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

IB002
Copy link
Contributor

@IB002 IB002 commented Jul 12, 2023

Related Issue:

Relates to #3955

Description:

increased bottom margin between interactive elements

Screenshots:

Before
Screenshot 2023-07-12 at 8 37 56 AM

After
Screenshot 2023-07-11 at 10 05 25 AM

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 9271f06
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/64b1d1bc45e2350008effd65
😎 Deploy Preview https://deploy-preview-4682--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -54,7 +54,7 @@ const localStyles = `
<style>

.fd-avatar {
margin: 0 0.5rem;
margin: 0.5rem 0.5rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the value is the same in horizontal and vertical direction you can just use:

margin: 0.5rem;

@InnaAtanasova
Copy link
Contributor

your PR title should be docs(styles): increased bottom margin between interactive elements as the changes concern the doc files, not the code for the library. When you do changes in the CSS code for the components then it's fix. New features, enhancements, etc are feat

@InnaAtanasova InnaAtanasova changed the title fix(styles): increased bottom margin between interactive elements docs(styles): increased bottom margin between interactive elements Jul 12, 2023
@InnaAtanasova
Copy link
Contributor

your PR title should be docs(styles): increased bottom margin between interactive elements as the changes concern the doc files, not the code for the library. When you do changes in the CSS code for the components then it's fix. New features, enhancements, etc are feat

I changed it, the comment is just for your information.

@InnaAtanasova
Copy link
Contributor

To trigger the visual changes your commit message must contain [ci visual] in it. For example:

docs(styles): increased bottom margin between interactive elements [ci visual]

Please do this with your fix for the margin so the visual checks run. Thanks

@InnaAtanasova InnaAtanasova added the Doc website documentation website label Jul 12, 2023
@InnaAtanasova InnaAtanasova added this to the Sprint 117 milestone Jul 12, 2023
@IB002 IB002 changed the title docs(styles): increased bottom margin between interactive elements docs(styles): avatar styles & examples Jul 12, 2023
@IB002 IB002 changed the title docs(styles): avatar styles & examples docs(styles): increased bottom margin between interactive elements Jul 12, 2023
@IB002 IB002 changed the title docs(styles): increased bottom margin between interactive elements docs(styles): increased bottom margin between interactive elements[ci visual] Jul 12, 2023
@IB002 IB002 changed the title docs(styles): increased bottom margin between interactive elements[ci visual] docs(styles): increased bottom margin between interactive elements [ci visual] Jul 12, 2023
@droshev droshev force-pushed the fix/avatar branch 2 times, most recently from 7d13f29 to 17e397c Compare July 14, 2023 21:07
@droshev droshev merged commit e8630e0 into main Jul 14, 2023
8 checks passed
@droshev droshev deleted the fix/avatar branch July 14, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doc website documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants