Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): design review fixes for Icon Tab Bar [ci visual] #4686

Merged
merged 1 commit into from
Jul 14, 2023
Merged

fix(styles): design review fixes for Icon Tab Bar [ci visual] #4686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/styles/src/icon-tab-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,8 @@ $fd-icon-tab-bar-semantic-values: (
height: $fd-icon-tab-bar-multi-click-button-size;
min-width: $fd-icon-tab-bar-multi-click-button-size;

--fdButton_Hover_Shadow: none;

@include fd-focus() {
&::after {
border-radius: var(--fdIcon_Tab_Bar_Multi_Click_Button_Focus_Radius);
Expand Down Expand Up @@ -805,8 +807,6 @@ $fd-icon-tab-bar-semantic-values: (
--fdIconTabBar_Overflow_Button_Border_Color: var(--sapButton_Hover_BorderColor);
--fdIconTabBar_Overflow_Button_Text_Color: var(--fdIcon_Tab_Bar_Overflow_Button_Text_Color_Hover);
--fdIconTabBar_Overflow_Button_Icon_Color: var(--fdIcon_Tab_Bar_Overflow_Button_Icon_Color_Hover);

box-shadow: var(--fdIcon_Tab_Bar_Overflow_Button_Hover_Box_Shadow);
}

@include fd-active() {
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/stories/Components/icon-tab-bar/icon-tab-bar.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Counter.storyName = 'Counters and Text';
Counter.parameters = {
docs: {
description: {
story: 'Counters can be shown on top of labels. In this case you need to apply the `fd-icon-tab-bar--counters` modifier class. <br> The control has the same look and feel in Cozy and Compact mode.'
story: '<code>NOTE: This is no longer recommended.</code> Counters can be shown on top of labels. In this case you need to apply the `fd-icon-tab-bar--counters` modifier class. <br> The control has the same look and feel in Cozy and Compact mode.'
}
}
};
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/stories/Components/icon-tab-bar/single-click.example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
<li role='presentation' class='fd-icon-tab-bar__item fd-icon-tab-bar__item--overflow' style="left: 23rem;">
<div class="fd-popover">
<div class="fd-popover__control">
<button class='fd-icon-tab-bar__overflow'>
<button class='fd-icon-tab-bar__overflow is-active'>
<span class='fd-icon-tab-bar__overflow-text'>More</span>
<i class='sap-icon--slim-arrow-down' role='presentation'></i>
</button>
Expand Down
2 changes: 1 addition & 1 deletion packages/styles/stories/Components/icon-tab-bar/text-only-closable.example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ <h4>Overflow</h4>
<li role="presentation" class="fd-icon-tab-bar__item fd-icon-tab-bar__item--overflow" style="left: 23rem">
<div class="fd-popover">
<div class="fd-popover__control">
<button class="fd-icon-tab-bar__overflow">
<button class="fd-icon-tab-bar__overflow is-active">
<span class="fd-icon-tab-bar__overflow-text">More</span>
<i class="sap-icon--slim-arrow-down" role="presentation"></i>
</button>
Expand Down
4 changes: 2 additions & 2 deletions packages/styles/tests/__snapshots__/styles.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16274,7 +16274,7 @@ exports[`Check stories > Components/Icon Tab Bar > Story SingleClick > Should ma
<li role='presentation' class='fd-icon-tab-bar__item fd-icon-tab-bar__item--overflow' style=\\"left: 23rem;\\">
<div class=\\"fd-popover\\">
<div class=\\"fd-popover__control\\">
<button class='fd-icon-tab-bar__overflow'>
<button class='fd-icon-tab-bar__overflow is-active'>
<span class='fd-icon-tab-bar__overflow-text'>More</span>
<i class='sap-icon--slim-arrow-down' role='presentation'></i>
</button>
Expand Down Expand Up @@ -16764,7 +16764,7 @@ exports[`Check stories > Components/Icon Tab Bar > Story TextOnlyClosable > Shou
<li role=\\"presentation\\" class=\\"fd-icon-tab-bar__item fd-icon-tab-bar__item--overflow\\" style=\\"left: 23rem\\">
<div class=\\"fd-popover\\">
<div class=\\"fd-popover__control\\">
<button class=\\"fd-icon-tab-bar__overflow\\">
<button class=\\"fd-icon-tab-bar__overflow is-active\\">
<span class=\\"fd-icon-tab-bar__overflow-text\\">More</span>
<i class=\\"sap-icon--slim-arrow-down\\" role=\\"presentation\\"></i>
</button>
Expand Down
Loading