Improves alert example in docu (#3834)

SAP · Jul 29, 2024 · ee9239f · ee9239f
1 parent f30a186
commit ee9239f
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 6 deletions.
diff --git a/.gitignore b/.gitignore
@@ -7,6 +7,7 @@ node_modules
 .angulardoc.json
 .vscode/diff
 .vscode/settings.json
+.vs
 
 .changelog
 

diff --git a/client/luigi-client.d.ts b/client/luigi-client.d.ts
@@ -155,7 +155,7 @@ export declare interface UxManager {
    * @example
    * import LuigiClient from '@luigi-project/client';
    * const settings = {
-   *  text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject}",
+   *  text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject} or {neverShowItAgain}",
    *  type: 'info',
    *  links: {
    *    goToHome: { text: 'homepage', url: '/overview' },

diff --git a/client/luigi-element.d.ts b/client/luigi-element.d.ts
@@ -84,7 +84,7 @@ export declare interface UxManager {
    * @example
    * import LuigiClient from '@luigi-project/client';
    * const settings = {
-   *  text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject}",
+   *  text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject} or {neverShowItAgain}",
    *  type: 'info',
    *  links: {
    *    goToHome: { text: 'homepage', url: '/overview' },

diff --git a/client/src/uxManager.js b/client/src/uxManager.js
@@ -141,7 +141,7 @@ class UxManager extends LuigiClientBase {
    * @example
    * import LuigiClient from '@luigi-project/client';
    * const settings = {
-   *  text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject}",
+   *  text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject} or {neverShowItAgain}",
    *  type: 'info',
    *  links: {
    *    goToHome: { text: 'homepage', url: '/overview' },

diff --git a/core/src/Alerts.svelte b/core/src/Alerts.svelte
@@ -66,6 +66,9 @@
   function addClickListener(link, alertId) {
     try {
       const linkElem = document.getElementById(link.elemId);
+      if (!linkElem) {
+        return;
+      }
       if (linkElem.dismissListener) {
         linkElem.removeEventListener('click', linkElem.dismissListener);
       }

diff --git a/core/src/core-api/ux.js b/core/src/core-api/ux.js
@@ -42,7 +42,7 @@ class LuigiUX {
    * @since 0.6.4
    * @example
    * const settings = {
-   *  text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject}",
+   *  text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject} or {neverShowItAgain}",
    *  type: 'info',
    *  links: {
    *    goToHome: { text: 'homepage', url: '/overview' },

diff --git a/docs/luigi-client-api.md b/docs/luigi-client-api.md
@@ -1137,7 +1137,7 @@ Shows an alert.
 ```javascript
 import LuigiClient from '@luigi-project/client';
 const settings = {
- text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject}",
+ text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject} or {neverShowItAgain}",
  type: 'info',
  links: {
    goToHome: { text: 'homepage', url: '/overview' },

diff --git a/docs/luigi-core-api.md b/docs/luigi-core-api.md
@@ -998,7 +998,7 @@ Shows an alert.
 
 ```javascript
 const settings = {
- text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject}",
+ text: "Ut enim ad minim veniam, {goToHome} quis nostrud exercitation ullamco {relativePath}. Duis aute irure dolor {goToOtherProject} or {neverShowItAgain}",
  type: 'info',
  links: {
    goToHome: { text: 'homepage', url: '/overview' },