-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump svelte and svelte-preprocess in /core #4054
base: main
Are you sure you want to change the base?
Conversation
Bumps [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) and [svelte-preprocess](https://github.com/sveltejs/svelte-preprocess). These dependencies needed to be updated together. Updates `svelte` from 3.54.0 to 5.6.2 - [Release notes](https://github.com/sveltejs/svelte/releases) - [Changelog](https://github.com/sveltejs/svelte/blob/main/packages/svelte/CHANGELOG-pre-5.md) - [Commits](https://github.com/sveltejs/svelte/commits/[email protected]/packages/svelte) Updates `svelte-preprocess` from 4.10.7 to 6.0.3 - [Changelog](https://github.com/sveltejs/svelte-preprocess/blob/main/CHANGELOG.md) - [Commits](https://github.com/sveltejs/svelte-preprocess/commits/v6.0.3) --- updated-dependencies: - dependency-name: svelte dependency-type: direct:development - dependency-name: svelte-preprocess dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
It seems there's no need to update Svelte to v5, as this vulnerability has been fixed already in version 4.2.19 Also - to keep things compatible - 'svelte-preprocess' might be updated to version 5.1.4 instead of v6 What's more, proper migration from Svelte v3 to v4 needs to be handled: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower versions should be tested first - also against other deps in core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Bundle stats BEFORE upgrade: Bundle stats AFTER upgrade: |
try out with nightly |
test btptoollayout as well |
Bumps svelte and svelte-preprocess. These dependencies needed to be updated together.
Updates
svelte
from 3.54.0 to 5.6.2Release notes
Sourced from svelte's releases.
... (truncated)
Changelog
Sourced from svelte's changelog.
... (truncated)
Commits
85dec47
Version Packages (#14557)a220330
chore: make if blocks tree-shakable (#14549)51c9eac
Version Packages (#14556)a151ae1
fix: handle static form values in combination with default values (#14555)c0746e0
Version Packages (#14552)a57e747
feat: default values for form elements (#14289)c55af4a
Version Packages (#14548)86ae349
fix: better error messages for invalid HTML trees (#14445)4e77bde
fix: respect the unidirectional nature of time (#14541)d511104
chore: make test more robust (#14550)Maintainer changes
This version was pushed to npm by svelte-admin, a new releaser for svelte since your current version.
Updates
svelte-preprocess
from 4.10.7 to 6.0.3Changelog
Sourced from svelte-preprocess's changelog.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.