Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showAlert promise for webcomponents #4115

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

showAlert promise for webcomponents #4115

wants to merge 7 commits into from
+1,990 −1,783

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Jan 16, 2025 •
edited
Loading

No description provided.

@JohannesDoberer JohannesDoberer changed the title showAlert promise closeAlert handling for webcomponents Jan 16, 2025
@JohannesDoberer JohannesDoberer marked this pull request as ready for review January 16, 2025 19:18
@JohannesDoberer JohannesDoberer changed the title closeAlert handling for webcomponents showAlert promise for webcomponents Jan 16, 2025
@JohannesDoberer JohannesDoberer added enhancement New feature or request container ora ora related issues labels Jan 16, 2025
@walmazacn walmazacn self-assigned this Jan 17, 2025
walmazacn
walmazacn approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both feature and tests work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmazacn walmazacn walmazacn approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@walmazacn walmazacn

Labels
container enhancement New feature or request ora ora related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesDoberer @walmazacn