[SAPBTPCFS-15469] Update Service Instance on change of 'parametersFro…

…m' secret
SAP · Dec 18, 2024 · ece2c30 · ece2c30
1 parent ba0e3f2
commit ece2c30
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/controllers/serviceinstance_controller.go b/controllers/serviceinstance_controller.go
@@ -565,7 +565,7 @@ func (r *ServiceInstanceReconciler) buildSMRequestParameters(ctx context.Context
 	}
 
 	//sync instance labels
-	for key := range serviceInstance.Labels {
+	for key, value := range serviceInstance.Labels {
 		if strings.HasPrefix(key, common.InstanceSecretRefLabel) {
 			if secretName, ok := instanceLabels[key]; !ok {
 				instanceLabelsChanged = true
@@ -576,7 +576,7 @@ func (r *ServiceInstanceReconciler) buildSMRequestParameters(ctx context.Context
 			}
 		} else {
 			// this label not related to secrets, add it
-			instanceLabels[key] = serviceInstance.Labels[key]
+			instanceLabels[key] = value
 		}
 	}
 	if instanceLabelsChanged {

diff --git a/controllers/serviceinstance_controller_test.go b/controllers/serviceinstance_controller_test.go
@@ -1489,7 +1489,7 @@ var _ = Describe("ServiceInstance controller", func() {
 				Expect(k8sClient.Update(ctx, paramsSecret)).To(Succeed())
 				Expect(fakeClient.UpdateInstanceCallCount()).To(Equal(0))
 			})
-			FIt("should not update instance with the secret change after removing SubscribeToSecretChanges", func() {
+			It("should not update instance with the secret change after removing SubscribeToSecretChanges", func() {
 				instanceSpec.SubscribeToSecretChanges = pointer.Bool(true)
 				serviceInstance = createInstance(ctx, fakeInstanceName, instanceSpec, nil, true)
 				smInstance, _, _, _, _, _ := fakeClient.ProvisionArgsForCall(0)