CVE-2007-4559 Patch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This relies on 2 other things that should be covered in documentation:
1. install pkg-config, which does not come with MacOS.
brew install pkg-config
if this is not installed, you'll get a warning, but the build will continue
without including libcrypto
2. Install libcrypto, using brew:
https://gist.github.com/aklap/e885721ef15c8668ed0a1dd64d2ea1a7
this note explains a couple of symbolic links you need to add
If you've installed pkg-config but not libcrypto, the build will
continue without including libcrypto
Don't attempt to run thirdparty/extract/src/docx_template_build.py if we don't have python-3.6 or later. The generated files are in git so this works ok.
Apple Preview doesn't like the Type0 embedded font file to be Type1C.
Previously image masks were not handled specially when being redacted. Because image masks a stored inverted in the PDF, when redacting them we need to invert the samples, perform the redaction including erasing pixels and drawing black boxes as requested. Finally we need to remember the image mask flag so that the image is written correctly when the PDF is saved.
If an XObject exists, reuse it.
Conflicts: .gitmodules
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching CVE-2007-4559
Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.
If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.