Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev #9

Merged
merged 7 commits into from
Sep 18, 2023
Merged

Dev #9

merged 7 commits into from
Sep 18, 2023

Conversation

MakinZeel
Copy link
Collaborator

Handled Issues.

  • Added checks to ensure the user is allowed to access the course content.
  • bugfixes
  • corrected style
  • added Moodle GitHub code checker (fixed all errors/warnings)

st143971 added 7 commits June 28, 2023 13:12
Addressing Issue #8:
a9f44d6 
Replaced visibility check of courses from custom db query to 'can_access_course()' Moodle api.
Because the course content (books) is the target of our block, the user needs to have access to this course.
- Updated course_access checks using moodles can_access_course instea…
a13c83c 
…d of custom one (addressing #8)

- updated strings addressing #6

- added the customary content check for the block addressing #4

- updated thirdpartylibs.xml addressing #3

- updated error handling & management

- other bugfixes
Addressing Warnings and Errors found via moodle's GitHub Action check.
dcb901f
Addressing the Warnings and Errors of Moodle's GitHub Action automati…
b97e3d1 
…c code checker.
Addressing the Warnings and Errors of Moodle's GitHub Action automati…
edb2bcf 
…c code checker
Addressing the Warnings and Errors of Moodle's GitHub Action automati…
8fe94b8 
…c code checker
Added context validation to external function, addressing #7
838430e
@MakinZeel MakinZeel merged commit 0611b79 into main Sep 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MakinZeel