Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show spinner on label creation #4458

Merged
merged 13 commits into from
Jan 18, 2024
Merged

Show spinner on label creation #4458

merged 13 commits into from
Jan 18, 2024

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented Jan 2, 2024

Any background context you want to provide?

See ticket

What's this PR do?

When a user clicks "Done" on the add/remove label modal, all buttons become disabled and a spinner appears. Once the backend request has been processed the modal closes and the spinner disappears

How should this be manually tested?

Import 1000 records, select all, add a label, click done

What are the relevant tickets?

#4145

Screenshots (if appropriate)

Screenshot 2024-01-02 at 4 00 30 PM

@perryr16 perryr16 marked this pull request as ready for review January 5, 2024 15:05
@axelstudios
Copy link
Member

axelstudios commented Jan 12, 2024

PR titles are automatically included in the changelog:

  • Update PR title to be consistent with changelog entries

@perryr16 perryr16 changed the title 4145 add label spinner Show spinner on label creation Jan 12, 2024
@kflemin kflemin merged commit 04f66bb into develop Jan 18, 2024
8 checks passed
@kflemin kflemin deleted the 4145-add-label-spinner branch January 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants