Sensor reading performance improvement #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelstudios
added
the
Enhancement
haneslinger
reviewed
Jan 5, 2024
| @@ -51,8 +51,7 @@ def _usages_by_exact_times(self, page, per_page): | |||
| if self.showOnlyOccupiedReadings: | |||
| sensor_readings = sensor_readings.filter(is_occupied=True) | |||
|
|
|||
| # order by id **greatly** speeds this up (cause of indexing, I think | |||
There was a problem hiding this comment.
you had me make a commit just to add this comment, why are you removing it?
There was a problem hiding this comment.
Because that change is gone now in favor of a better one - also, you merged your PR before it was reviewed/approved, so I couldn't make the change there.
haneslinger
reviewed
Jan 5, 2024
Comment on lines
-82
to
-83
| if self.showOnlyOccupiedReadings: | ||
| sensor_readings = sensor_readings.filter(is_occupied=True) |
There was a problem hiding this comment.
Why isn't this needed anymore?
There was a problem hiding this comment.
It's already handled at the top, no need to do it twice
haneslinger
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Removes a long, unnecessary
COUNTquery, which cuts query time by 40%How should this be manually tested?
Browse to the sensors page for an org with, ideally, millions of readings
What are the relevant tickets?
#3328