Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update viewer group permissions #4925

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

perryr16
Copy link
Contributor

@perryr16 perryr16 commented Jan 14, 2025

Any background context you want to provide?

What's this PR do?

  • Allows users to hit inventory_groups/filter

How should this be manually tested?

log in with a viewer, inventory list should be available

What are the relevant tickets?

Screenshots (if appropriate)

@perryr16 perryr16 added the Bug label Jan 14, 2025
@@ -50,7 +50,7 @@ angular.module('SEED.service.inventory_group', []).factory('inventory_group_serv
inventory_type
}
}).then((response) => {
const groups = response.data.data.sort((a, b) => naturalSort(a.name, b.name));
const groups = response.data.sort((a, b) => naturalSort(a.name, b.name));
Copy link
Contributor Author

@perryr16 perryr16 Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new viewset permission changes structure of the response

@perryr16 perryr16 changed the title viewer group filter permissions Update viewer group permissions Jan 14, 2025
@perryr16 perryr16 requested a review from haneslinger January 14, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant