Remove server settings from the session cookie #4927
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
The
sessionid
cookie should have only the minimal session-specific data necessary, and not server settings that can become out-of-sync if stored in session tokensWhat's this PR do?
Overrides the
two_factor.views.core.LoginView.render
method to make the backend settingINCLUDE_ACCT_REG
available to the view template without storing it in each user's session cookieHow should this be manually tested?
In
local_untracked.py
toggle theINCLUDE_ACCT_REG = True
variable and check that the login page correctly renders (or hides) theCreate my Account
buttonOptionally inspect the session cookie data and ensure the
include_acct_reg
is no longer included. Copy yoursessionid
cookie value and run the following commands:The new session data (for a logged-out user) should show the following: