Add processing for ICLR-GREAT Paper and Fix bugs #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add JsonVisitor to preprocess dataset for the ICLR-GREAT model. Also hack-fix some of the NullPointer / Peek errors.
Refactored DataGenerator in general and added BufferedOutputStream to flush and avoid running out of memory with bigger datasets.
If processing huge datasets there are bound to be code that on purpose doesn't compile. This commit will catch those examples and ignores them.
mauricioaniche
requested changes
Aug 12, 2020
src/main/java/com/github/sergdelft/j2graph/walker/json/JsonVisitor.java
Outdated
Show resolved
Hide resolved
|
|
||
| /** | ||
| * Tests that exercise the classes with imports. | ||
| * This was a bug (issue #3) |
There was a problem hiding this comment.
is this really related to issue #3 ?
There was a problem hiding this comment.
Oh, that's a copy-paste error. Will fix.
There was a problem hiding this comment.
I still see 3 here?
There was a problem hiding this comment.
Oops, I fixed it in the Enum test. 🤦 Pushed for the unparsable code test as well now.
There was a problem hiding this comment.
Oops, I fixed the Enum test that had the same error. Added the commit for UnparsableCode. I guess the IllegalArgumentException is the expected output for unparsable code?
|
@mauricioaniche , made the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds DataGenerator for ICLR2020-Great paper and also fixes some bugs.
2 Additional tests were added. One for unparsable code (expecting an illegalArgumentException) and one for Enums.
The enum test has a @todo tag since j2graph currently fails to handle them.