Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/175 #177

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Feature/175 #177

merged 4 commits into from
Feb 24, 2025

Conversation

cidarm
Copy link
Collaborator

@cidarm cidarm commented Feb 24, 2025

Critical Changes

New Permission Validator apex class to check field level security.

Changes

Modified the following apex classes to check field level security

  • GGW_ApplicationCtrl.cls
  • GGW_SampleData.cls
  • GGW_UTIL.cls

Add New User creation to the Grant Content Kit Data factory class.

  • GGW_TestDataFactory.clse

Added GGW_PermissionValidator.cls to Grant Content Kit Permission Set.

Issues Closed

#175

@cidarm cidarm requested a review from iandrosov February 24, 2025 20:08
Copy link
Collaborator

@iandrosov iandrosov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment I have is use of Describe Schema introduces performance impact for data changes. Grant records are small numbers and no massive data batches I think it is safe to make this changes

@iandrosov iandrosov merged commit 1f6c8fc into main Feb 24, 2025
2 checks passed
@cidarm cidarm mentioned this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting Review
Development

Successfully merging this pull request may close these issues.

2 participants