Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure two decimal places for currency values #215

Merged
merged 2 commits into from
May 9, 2024

Conversation

CollinAlpert
Copy link
Contributor

Currently when entering prices like "81,10" or "45,50" (values ending with a zero), the trailing zero is omitted in the display:
Screenshot 2024-05-09 at 21 00 29

This PR corrects the behavior. Disclaimer: I have never worked with React before, so there is probably a better way to do this. I will happily take pointers.

Copy link
Contributor

@mikonse mikonse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,

thanks a lot for the PR, definitely a good addition for more consistency.

I've only got the one small remark otherwise this looks good!

frontend/apps/web/src/components/NumericInput.tsx Outdated Show resolved Hide resolved
@mikonse mikonse merged commit d26106d into SFTtech:master May 9, 2024
9 of 10 checks passed
@CollinAlpert CollinAlpert deleted the floating-price branch May 10, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants