Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the calling convention in sick_scan_xd_api_wrapper.c from __stdcall to __cdecl #321

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Sertzu
Copy link

@Sertzu Sertzu commented Apr 23, 2024

This is a proposed solution to issue #310

Changing the calling convention from __stdcall to __cdecl here enables the library to operate in 32-bit mode. Since the .dll is also compiled with __cdecl as the calling convention this makes sense.

However, we weren't able to test if the library still works fine with real hardware though.

Changing the calling convention from __stdcall to __cdecl here makes the library run in 32-bit mode. Since the .dll is also compiled with __cdecl as the calling convention this makes sense. We weren't able to test if the library still works fine with real hardware though.
@rostest
Copy link
Collaborator

rostest commented Apr 24, 2024

Thanks for your pull request, we appreciate your feedback and input. We will merge it by adding a customizable define to declare a specific calling convention. This way the calling convention can be set by a cmake flag, if required.

Calling conventions depend on the system; different architectures use different defaults. Calling conventions can be e.g.:

We will therefore introduce a define (cmake flag), which can be overwritten if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants