Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding taxi #120

Merged
merged 4 commits into from
Mar 20, 2024
Merged

adding taxi #120

merged 4 commits into from
Mar 20, 2024

Conversation

ue71603
Copy link
Collaborator

@ue71603 ue71603 commented Aug 23, 2023

from #115

@ue71603 ue71603 mentioned this pull request Aug 23, 2023
@haeckerbaer
Copy link
Collaborator

Decision on 24.08.2023:
Add annotation to taxi: it should not be confused with "there is taxi service available at the station" since it is actually a scheduled service for example replacing a bus. Lasse will update.

@lassetyr
Copy link

lassetyr commented Jan 2, 2024

I still do not have access to update this PR, so I am unable to add the requested change.

Suggestion:

Note: To be used to indicate that a scheduled service - e.g. usually operated a bus or train - is operated by taxi

@ue71603
Copy link
Collaborator Author

ue71603 commented Jan 8, 2024

@lassetyr Hi Lasse. If you tell me, what I should do, I can do it. Or you do it online

  1. mark the lines that you want to change and press on the +
  2. add the content of the lines
  3. change the lines to include the comment
    image

@ue71603 ue71603 requested a review from skinkie March 20, 2024 14:29
@ue71603 ue71603 merged commit eba6b89 into integration Mar 20, 2024
@ue71603 ue71603 deleted the taxi-vehicle-mode branch March 20, 2024 14:56
lassetyr added a commit to entur/siri-java-model that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants