Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text support for extensions. Thanks, @sn4k3 #39

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Conversation

SKProCH
Copy link
Owner

@SKProCH SKProCH commented Jan 21, 2025

Rework of #38

Thanks, @sn4k3

@SKProCH SKProCH self-assigned this Jan 21, 2025
@SKProCH SKProCH merged commit fe5a4c5 into master Jan 21, 2025
1 check passed
@SKProCH SKProCH deleted the textExtensions branch January 21, 2025 18:22
@sn4k3
Copy link

sn4k3 commented Jan 21, 2025

Thanks, I will test :)

Minor stuff, but should [ConstructorArgument("textfirst")] follow the rule of capital [ConstructorArgument("textFirst")] ?

Also readme should be fixed: <Button Content="{materialIcons:MaterialIconExt Kind=Play, Text=Play}" /> to <Button Content="{materialIcons:MaterialIconTextExt Kind=Play, Text=Play}" />

@SKProCH
Copy link
Owner Author

SKProCH commented Jan 21, 2025

Yeah, i missed that. Gonna fix tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants