Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Q related dependencies #24

Merged
merged 2 commits into from
Oct 31, 2016
Merged

Upgrade Q related dependencies #24

merged 2 commits into from
Oct 31, 2016

Conversation

zamb3zi
Copy link
Contributor

@zamb3zi zamb3zi commented Oct 31, 2016

Currently Styliner is failing due to deprecation in Q:

at Function.Q_deprecate [as isPromiseAlike] (/home/cds/tcmweb/node_modules/styliner/node_modules/qx/node_modules/q/q.js:166:21)
at eagerWhen (/home/cds/tcmweb/node_modules/styliner/node_modules/qx/Qx.js:52:8)
at /home/cds/tcmweb/node_modules/styliner/node_modules/qx/Qx.js:61:11
at Array.map (native)
at /home/cds/tcmweb/node_modules/styliner/node_modules/qx/Qx.js:60:20
at Promise_then_fulfilled (/home/cds/tcmweb/node_modules/styliner/node_modules/qx/node_modules/q/q.js:766:44)
at Promise_done_fulfilled (/home/cds/tcmweb/node_modules/styliner/node_modules/qx/node_modules/q/q.js:835:31)
at Fulfilled_dispatch [as dispatch] (/home/cds/tcmweb/node_modules/styliner/node_modules/qx/node_modules/q/q.js:1229:9)
at Promise_done_task (/home/cds/tcmweb/node_modules/styliner/node_modules/qx/node_modules/q/q.js:871:28)
at RawTask.call (/home/cds/tcmweb/node_modules/asap/asap.js:40:19)```

Upgrading to the latest versions resolves this problem.

@SLaks SLaks merged commit b0ddebd into SLaks:master Oct 31, 2016
@mattandrews
Copy link

The downgrading here of q-io (after it was upgraded here) has caused me huge issues, not least in tracking down the cause of the problem.

It stems from the sloppy implementation/naming of this library which is required by q-io, which this library requires, which in turn is required by activator (which my project uses).

I appreciate all of these issues stem from a downstream dependency, but was this change to q-io required in order to upgrade q?

@deitch
Copy link

deitch commented Mar 4, 2018

@IvanMMM just pointed me here from activator, see this issue. It took me a while to track down that it had been reverted.

I am not quite sure how to fix this with a styliner dependency. It seems we are dependent on whatever happens here. I will open a new issue here for tracking, but the question is the one @mattandrews asked: was the q-io downgrade necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants