Thinking about handwritten textual IR, but seems not feasible.

penne.todo

@@ -271,7 +271,10 @@ Rewrite using Data-Oriented Compiler Design for 0.5.0:
 	- Everything above at 100KLOC/s for responsive language server
 
 Development:
-	☐	Drop llvm-sys and generate LLVM BC and textual IR by hand
+	✘	Drop llvm-sys and generate textual LLVM IR by hand @cancelled (2024-04-13 21:44)
+		Requires calculating struct sizes by hand.
+		Means we lose constant folding.
+		Means we lose expression folding which means textual IR is much larger.
 	☐	Release 0.4.0
 		☐	Flesh out core and vendor/libc
 		☐	Add/check documentation for E359, E553

src/expander.rs

@@ -95,7 +95,7 @@ pub fn expand(modules: &mut [(std::path::PathBuf, Vec<Declaration>)])
 	}
 }
 
-/// Convenience method that calls [expand](expand) with a single module.
+/// Convenience method that calls [expand] with a single module.
 pub fn expand_one(
 	filename: &str,
 	declarations: Vec<Declaration>,
@@ -127,7 +127,7 @@ fn get_key_offset(
 	keys.iter().position(|x| x == filepath).or_else(|| {
 		path_of_includer
 			.parent()
-			.map(|path| path.join(filepath.clone()))
+			.map(|path| path.join(filepath))
 			.and_then(|path| keys.iter().position(|x| x == &path))
 	})
 }

src/resolved.rs

@@ -10,7 +10,8 @@
 pub use crate::builtin;
 pub use crate::common::DeclarationFlag;
 pub use crate::common::{BinaryOp, ComparisonOp, UnaryOp};
-pub use crate::generator::GeneratorBuiltin;
+
+pub(crate) use crate::generator::GeneratorBuiltin;
 
 use crate::value_type;
 

src/scoper/variable_references.rs

@@ -608,7 +608,7 @@ impl Analyzer
 			.expect("containee must be predeclared");
 
 		// The same goes for the container.
-		let mut container = self
+		let container = self
 			.containers
 			.iter_mut()
 			.find(|x| x.identifier.resolution_id == container_id)