Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -d switch for spacy script to download data file #153

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Aug 10, 2022

Add -d switch for spacy script to download data file

@jas88 jas88 requested a review from tznind August 10, 2022 15:58
@tznind tznind self-requested a review August 10, 2022 18:10
@tznind
Copy link
Contributor

tznind commented Aug 10, 2022

@jas any chance of updating this so that after downloading the language file it then runs with that file named?

That would allow for parallel execution e.g.

SpaCy -d file1 --port  123
SpaCy -d file2 --port  124

If thats complicated though we can address it in a subsequent PR

@jas88
Copy link
Member Author

jas88 commented Aug 10, 2022

Running two instances at once with -d would mean downloading twice (at best, at worst it might end up breaking something) - the -d operation should only be done once per install anyway.
spacy -d
spacy --port 123
spacy --port 124
will have the intended result though: download the data dependency, then run two parallel copies. (It's a threaded server, though, so one copy listening on a single port should server multiple clients anyway: no need for a second copy on a different port AFAICS?)

@tznind
Copy link
Contributor

tznind commented Aug 11, 2022

the -d operation should only be done once per install anyway.

I was imagining running two different language files (one in each instance). See #154 for more info. But I guess until we know more this is a good improvement and we probably don't need to block it for multi model support. Thanks

@tznind tznind merged commit 05c8943 into main Aug 11, 2022
@tznind tznind deleted the feature/spacy-download branch August 11, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants