Merge pull request #2 from SOFware/update-variable-names

Updating variable names to declare Notify

README.md

@@ -30,6 +30,15 @@ Add to your config/application.rb within your namespaced module
   end
 ```
 
+Add these variables to your env files
+
+```
+      NOTIFY_SLACK_WEBHOOK_URL
+      NOTIFY_SLACK_NOTIFY_CHANNEL
+      NOTIFY_CURRENT_REPOSITORY_URL
+      NOTIFY_TEST_RUN_ID
+```
+
 ### Debug your Slack setup
 
 Create rake task to test the connection to your Slack channel
@@ -38,13 +47,13 @@ Create rake task to test the connection to your Slack channel
 namespace :chat_notifier do
   desc "Tests chat notifier"
   task debug: :environment do
-    unless ENV["SLACK_WEBHOOK_URL"]
-      puts "You MUST set the environment variables for:\nSLACK_WEBHOOK_URL"
+    unless ENV["NOTIFY_SLACK_WEBHOOK_URL"]
+      puts "You MUST set the environment variables for:\nNOTIFY_SLACK_WEBHOOK_URL"
       return
     end
     ENV["DEBUG"] = "1"
-    ENV["CURRENT_REPOSITORY_URL"] = "https://example.com"
-    ENV["TEST_RUN_ID"] = "9999"
+    ENV["NOTIFY_CURRENT_REPOSITORY_URL"] = "https://example.com"
+    ENV["NOTIFY_TEST_RUN_ID"] = "9999"
     require "chat_notifier"
 
     failure = ChatNotifier::DebugExceptionLocation.new(location: "fake/path.rb")

lib/chat_notifier/chatter/slack.rb

@@ -12,11 +12,11 @@ def handles?(settings)
       end
 
       def webhook_url
-        settings.fetch("SLACK_WEBHOOK_URL", nil)
+        settings.fetch("NOTIFY_SLACK_WEBHOOK_URL", nil)
       end
 
       def channel
-        settings.fetch("SLACK_NOTIFY_CHANNEL", nil)
+        settings.fetch("NOTIFY_SLACK_NOTIFY_CHANNEL", nil)
       end
 
       def payload(data)

lib/chat_notifier/repository/github.rb

@@ -4,7 +4,7 @@ module ChatNotifier
   class Repository
     class Github < self
       def url
-        settings.fetch("CURRENT_REPOSITORY_URL", nil)
+        settings.fetch("NOTIFY_CURRENT_REPOSITORY_URL", nil)
       end
 
       def link(sha)

lib/chat_notifier/test_environment.rb

@@ -22,7 +22,7 @@ def ruby_version
     end
 
     def url
-      settings.fetch("CURRENT_REPOSITORY_URL")
+      settings.fetch("NOTIFY_CURRENT_REPOSITORY_URL")
     end
 
     def test_run_url

lib/chat_notifier/test_environment/github.rb

@@ -8,7 +8,7 @@ def test_run_url
       end
 
       def run_id
-        settings.fetch("TEST_RUN_ID")
+        settings.fetch("NOTIFY_TEST_RUN_ID")
       end
     end
   end

test/chatter/slack_test.rb

@@ -6,8 +6,8 @@
 describe ChatNotifier::Chatter::Slack do
   let(:settings) do
     {
-      "SLACK_WEBHOOK_URL" => "https://hooks.slack.com/abc/123",
-      "SLACK_NOTIFY_CHANNEL" => "#test"
+      "NOTIFY_SLACK_WEBHOOK_URL" => "https://hooks.slack.com/abc/123",
+      "NOTIFY_SLACK_NOTIFY_CHANNEL" => "#test"
     }
   end
 

test/repository/github_test.rb

@@ -6,7 +6,7 @@
 describe ChatNotifier::Repository::Github do
   let(:settings) do
     {
-      "CURRENT_REPOSITORY_URL" => "https://github.com/example/repo"
+      "NOTIFY_CURRENT_REPOSITORY_URL" => "https://github.com/example/repo"
     }
   end
   let(:repository) { ChatNotifier::Repository::Github.new(settings: settings) }

test/test_environment/github_test.rb

@@ -7,8 +7,8 @@
   let(:settings) do
     {
       "DEBUG" => false,
-      "CURRENT_REPOSITORY_URL" => "https://github.com/test/test_repo",
-      "TEST_RUN_ID" => "12345"
+      "NOTIFY_CURRENT_REPOSITORY_URL" => "https://github.com/test/test_repo",
+      "NOTIFY_TEST_RUN_ID" => "12345"
     }
   end
 
@@ -19,7 +19,7 @@
   end
 
   describe "#run_id" do
-    it "returns the TEST_RUN_ID from settings" do
+    it "returns the NOTIFY_TEST_RUN_ID from settings" do
       expect(ChatNotifier::TestEnvironment::Github.new(settings: settings).run_id).must_equal("12345")
     end
   end

test/test_environment_test.rb

@@ -5,7 +5,7 @@
   let(:settings) do
     {
       "DEBUG" => debug,
-      "CURRENT_REPOSITORY_URL" => "https://github.com/test/test_repo"
+      "NOTIFY_CURRENT_REPOSITORY_URL" => "https://github.com/test/test_repo"
     }
   end